-
Notifications
You must be signed in to change notification settings - Fork 19.7k
Implement vander function in keras.ops #21882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @shashaka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the keras.ops.vander function, providing a consistent API for creating Vandermonde matrices across NumPy, JAX, PyTorch, and TensorFlow backends. The implementation is well-structured, with backend-specific logic and a unified public-facing operation.
I've identified a couple of areas for improvement. There are potential precision loss issues in the NumPy and TensorFlow backend implementations when handling float64 inputs, for which I've provided suggestions. Additionally, I've noted that the input validation logic is duplicated across all backends and could be centralized in the main vander op function to improve maintainability.
Overall, this is a solid contribution. The tests are comprehensive, covering shapes, correctness, and dtypes.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #21882 +/- ##
==========================================
- Coverage 82.57% 82.57% -0.01%
==========================================
Files 577 577
Lines 59599 59657 +58
Branches 9351 9360 +9
==========================================
+ Hits 49213 49259 +46
- Misses 7978 7985 +7
- Partials 2408 2413 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds keras.ops.vander, which constructs a Vandermonde matrix from a 1-D input tensor.
Supported across NumPy, TensorFlow, PyTorch, and JAX backends.
Not supported on OpenVINO.