Tests updated to match working code #152
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two things: - Added an error_callback method that just prints to screen - Changed asserts such that lists are compared without regard for order of the items. The order isn't always consistent and this caused issues.
Author
|
Hi @keredson, my goal at looking into the code was to see if I can add progressive transcode-playback. I will take a look at that branch tomorrow to see how I can help. For now, please consider this update for tests to make them work again. |
Owner
|
cool, will take a look, thanks! fyi there's a streaming branch already. https://github.com/keredson/gnomecast/tree/streaming it only works with stereo tho, no 5.1. |
Author
|
Ah, okay, will check that branch. I originally thought http-live-streaming was the branch for this purpose. |
Owner
|
I've made multiple attempts. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things:
order of the items. The order isn't always consistent and this caused issues.