Do not zero-allocate the memory in pzstd::vector - #354
Merged
Conversation
Bench: 2186656
wdotmathree
approved these changes
Aug 7, 2026
wdotmathree
left a comment
wdotmathree
left a comment
Collaborator
There was a problem hiding this comment.
All comments aren't important to fix due to the fact that all T being used are trivially constructable. However they will become legitimate correctness bugs if other values of T are used in the future.
|
|
||
| vector() : sz(0) {} | ||
|
|
||
| void push_back(T value) noexcept { |
Collaborator
There was a problem hiding this comment.
Takes value by value. Should have 2 signatures: one taking const reference, and one taking rvalue.
| vector() : sz(0) {} | ||
|
|
||
| void push_back(T value) noexcept { | ||
| data[sz++] = value; |
Collaborator
There was a problem hiding this comment.
Calls assignment operator instead of constructor.
Collaborator
There was a problem hiding this comment.
Doesn't call destructor.
Collaborator
There was a problem hiding this comment.
Doesn't call destructor.
wdotmathree
reviewed
Aug 7, 2026
Collaborator
There was a problem hiding this comment.
Takes value by value. Should take const reference.
Bench: 2186656
kevlu8
force-pushed
the
dont-alloc-vector
branch
from
August 7, 2026 20:31
58dbef1 to
5dfd3dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be a slight speedup, somewhere around ~5%
https://ob.int0x80.ca/test/979/
Bench: 2186605