[Issue-1111] Move Realm Attributes to its own Resource #1327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhigdon
force-pushed
the
issue-1111-realm-attributes-resource
branch
2 times, most recently
from
9d977c0 to
1c97b93
Compare
Contributor
|
@rhigdon I think if we add this, we should offer both options as mutually exclusive. If we removed the current way, we would need a state migration and also ask everybody to adapt their configuration so this would be quite a breaking change. |
Author
That sounds good to me. Thanks for the direction on this! |
rhigdon
force-pushed
the
issue-1111-realm-attributes-resource
branch
from
1c97b93 to
83e38a6
Compare
this will help decouple the realms attributes and allow reuse in modules without relying on the entire realm configuration. use is mutually exclusive between this resource and the realm attributes Signed-off-by: Ryan H <[email protected]>
rhigdon
force-pushed
the
issue-1111-realm-attributes-resource
branch
from
f903b16 to
2907e7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will help decouple the realms attributes and allow reuse in modules
without relying on the entire realm configuration.