-
Notifications
You must be signed in to change notification settings - Fork 378
add connection_pooling params for userfederation #1374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add connection_pooling params for userfederation #1374
Conversation
72fb0bd to
13b7e01
Compare
|
@mawenge Thanks for you contribution. However, there are quite some test failures. Can you have a look? |
13b7e01 to
07d5fcd
Compare
I have fixed the tests, but after I rebase the main branch, there is a new error, and this seems not related to my change, can you please help take a look for this? |
|
@mawenge The error should be fixed in main, maybe you need another rebase? Also, I assume the current default for connection pooling is disabled. We should not change the default for this value as this would be an incompatible change. Can you please let it default to false? |
Signed-off-by: wenge <[email protected]>
Signed-off-by: wenge <[email protected]>
Signed-off-by: wenge <[email protected]>
Signed-off-by: wenge <[email protected]>
Signed-off-by: wenge <[email protected]>
563c111 to
71d7dc5
Compare
yes, I have rebased main branch and change the default value to false, please review again, thanks |
sschu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I made this change to add a parameter connection_pooling for resource_ldap_user_federation, default is true
testing:
I have made local manual test that provide this parameter and they works