Fix test reliability and DEBUG assertion correctness for &! operator#163
Closed
Copilot wants to merge 2 commits intothreadJobOperatorfrom
Closed
Fix test reliability and DEBUG assertion correctness for &! operator#163Copilot wants to merge 2 commits intothreadJobOperatorfrom
Copilot wants to merge 2 commits intothreadJobOperatorfrom
Conversation
… add Wait-Job timeouts, fix DEBUG assertions Co-authored-by: kilasuit <6355225+kilasuit@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add ThreadJobOperator
Fix test reliability and DEBUG assertion correctness for &! operator
Mar 11, 2026
Repository owner
locked and limited conversation to collaborators
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review feedback on the
&!(ThreadJob background operator) implementation identified brittle test patterns and a broken DEBUG assertion.Test fixes (
ThreadJobBackgroundOperator.Tests.ps1)$job.PSObject.TypeNames | Should -Contain 'ThreadJob'with$job.PSJobTypeName | Should -Be 'ThreadJob'—PSJobTypeNameis the canonical property;TypeNamesis implementation-specific and unreliable for this checkItblocks intry/finallywithRemove-Job -Force -ErrorAction Ignoreso jobs are removed even on assertion failureWait-Jobcalls now use-Timeout 30; tests throw explicitly if the timeout is hit rather than blocking the suite indefinitelyToken table assertion fix (
token.cs)The DEBUG-only
Diagnostics.Assertcalls validatings_staticTokenFlagsands_tokenTexttable lengths were still anchored toTokenKind.Clean(170) as the last enum value. WithAmpersandExclaim = 171appended, these assertions would fire in DEBUG builds. Updated to useTokenKind.AmpersandExclaimas the sentinel.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.