Split default spec into sections #1986
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Android integration seems to be failing because Buildozer doesn't automatically accept the licenses. |
Member
|
--- a/setup.py
+++ b/setup.py
@@ -68,7 +68,7 @@ setup(
packages=[
'buildozer', 'buildozer.targets', 'buildozer.libs', 'buildozer.scripts'
],
- package_data={'buildozer': ['default.spec']},
+ package_data={'buildozer': ['default*.*']},
include_package_data=True,
install_requires=[
'pexpect', |
Member
|
Android CI fails because of the leading space in the commented SDK-license line. Removing that space (as in this patch) fixes the sed match. diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml
index 65c8f63..c1d9a9f 100644
--- a/.github/workflows/android.yml
+++ b/.github/workflows/android.yml
@@ -30,7 +30,7 @@ jobs:
- run: buildozer init
- name: SDK, NDK, and p4a download
run: |
- sed -i.bak "s/# android.accept_sdk_license = False/android.accept_sdk_license = True/" buildozer.spec
+ sed -i.bak "s/#android.accept_sdk_license = False/android.accept_sdk_license = True/" buildozer.spec
sed -i.bak "s/#p4a.branch = master/p4a.branch = develop/" buildozer.spec
buildozer android p4a -- --help
# Install OS specific dependencies |
Contributor
Author
|
Good catch @T-Dynamos ! Now it's just iOS that is failing.. |
Member
|
It might be useful to add a |
Contributor
Author
|
Added that + possible cure for the deploy part for the ios part. |
Contributor
Author
|
PR is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt on splitting the default spec so the user will only be greeted with the minimal spec file if just running
buildozer init.Usage:
-
buildozer init-
buildozer init android-
buildozer init android --no-comments-
buildozer init ios-
buildozer init ios --no-docs-
buildozer init osxEach options includes the documentation and default text to the
buildozer.specfile and also aware not to include duplicates just to make it easier for the user.These steps involves making it easier in the future for the developers to change default values without messing up the documentations.
With this PR I have also updated the default values to match our daily usage with Buildozer.