Improve Performance of Variable Order Computation - #797
Merged
Conversation
monsterkrampe
approved these changes
Aug 4, 2026
monsterkrampe
left a comment
monsterkrampe
left a comment
Member
There was a problem hiding this comment.
Looks good. I did not verify how much faster this really is but I'm assuming that you tested that extensively :)
| } | ||
|
|
||
| #[derive(Debug)] | ||
| #[allow(dead_code)] |
Member
There was a problem hiding this comment.
Maybe we should remove the variants that we do not need anymore instead of marking this as dead_code?
At least if you came to the conclusion that Backward iteration is preferred anyway, then I'm ok with removing the others.
Member
Author
There was a problem hiding this comment.
Its the order which coincides with the one which we were previosly implcitly using (at least on the relevant benchmarks). I would just keep the old ones around in case we want to revisit this later.
Member
There was a problem hiding this comment.
Ah I see... Then let's keep it as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the dependency graph computation, the variable order computation had the highest impact on large rule sets. This PR improves the performance by reducing memory allocations and rewriting the algorithm.