Skip to content

docs(sidepanel): modal mode with close disabled (#DS-2313) - #1857

Open
NikGurev wants to merge 1 commit into
mainfrom
feat/DS-2313
Open

docs(sidepanel): modal mode with close disabled (#DS-2313)#1857
NikGurev wants to merge 1 commit into
mainfrom
feat/DS-2313

Conversation

@NikGurev

@NikGurev NikGurev commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@NikGurev NikGurev self-assigned this Aug 7, 2026
@NikGurev NikGurev added the documentation Improvements or additions to documentation label Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 1dce53f):

https://koobiq-next--prs-1857-13ihepvb.web.app

(expires Mon, 10 Aug 2026 12:31:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@NikGurev
NikGurev marked this pull request as ready for review August 7, 2026 12:58
@NikGurev
NikGurev requested a review from lskramarov as a code owner August 7, 2026 12:58
@artembelik
artembelik requested a balanced review from Copilot August 7, 2026 13:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds documentation for the sidepanel's modal mode with close disabled. It introduces a new docs example (sidepanel-disable-close) demonstrating the disableClose config option, which prevents closing via backdrop click or Escape while still allowing explicit close actions. It fits into the existing sidepanel documentation set alongside other examples like normal-mode, overlayed, and custom-injector.

Changes:

  • New docs example component (SidepanelDisableCloseExample + ExampleSidepanelDisableCloseContent) opening a modal sidepanel with disableClose: true.
  • Registered the example in index.ts, the generated example-module.ts, and the dev app module.
  • Added English/Russian documentation sections describing disableClose, plus a note about updating it dynamically via KbqSidepanelRef.config.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/docs-examples/components/sidepanel/sidepanel-disable-close/sidepanel-disable-close-example.ts New example demonstrating disableClose: true with a modal sidepanel.
packages/docs-examples/components/sidepanel/index.ts Exports and registers the new example.
packages/docs-examples/example-module.ts Generated registry entry and lazy-import case for the new example.
packages/components-dev/sidepanel/module.ts Adds the example to the dev app imports and template.
packages/components/sidepanel/sidepanel.en.md / sidepanel.ru.md New documentation subsection for disabling close.
packages/components/sidepanel/examples.sidepanel.en.md / examples.sidepanel.ru.md Notes that disableClose/hasBackdrop can be updated dynamically.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants