Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions apps/backend/crates/handler/src/handlers/task_extensions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ use service::db::is_postgres_unique_violation;
use service::task_activities::{
record_activity, record_label_diff, status_name, task_label_entries,
};
use std::collections::HashSet;

const BULK_MAX_TASKS: usize = 100;

Expand Down Expand Up @@ -295,6 +296,15 @@ pub async fn bulk_update_tasks(
if payload.task_ids.len() > BULK_MAX_TASKS {
return Err(AppError::BadRequest);
}
if let (Some(add), Some(remove)) = (
&payload.update.add_label_ids,
&payload.update.remove_label_ids,
) {
let remove: HashSet<&Uuid> = remove.iter().collect();
if add.iter().any(|id| remove.contains(id)) {
return Err(AppError::BadRequest);
}
}

let mut unique_ids = payload.task_ids.clone();
unique_ids.sort();
Expand Down Expand Up @@ -431,9 +441,9 @@ async fn apply_bulk_update(
}

// ラベル変更の前後スナップショット。実際に集合が変わったときだけ記録する。
// remove_label_ids などラベルを変える入力が増えたら、この判定式に足すこと。
// ラベルを変える入力が増えたら、この判定式に足すこと。
// ここを忘れると記録だけが静かに欠ける
let labels_will_change = update.add_label_ids.is_some();
let labels_will_change = update.add_label_ids.is_some() || update.remove_label_ids.is_some();
let before_labels = if labels_will_change {
Some(task_label_entries(&txn, task_id).await?)
} else {
Expand Down Expand Up @@ -472,6 +482,19 @@ async fn apply_bulk_update(
}
}

if let Some(ref label_ids) = update.remove_label_ids {
let mut unique = label_ids.clone();
unique.sort();
unique.dedup();
if !unique.is_empty() {
task_labels::Entity::delete_many()
.filter(task_labels::Column::TaskId.eq(task_id))
.filter(task_labels::Column::LabelId.is_in(unique))
.exec(&txn)
.await?;
}
}

if let Some(before_labels) = before_labels {
let after_labels = task_label_entries(&txn, task_id).await?;
record_label_diff(&txn, task_id, Some(user_id), &before_labels, &after_labels).await?;
Expand Down
Loading
Loading