Add unit tests for LanguageDetectionFilter#1
Merged
Conversation
This commit introduces a suite of unit tests for the `LanguageDetectionFilter` in `src/pipeline/filters/language_filter.rs`. The following test cases have been added: - `test_allowed_language`: Tests processing of a document in an allowed language. - `test_disallowed_language`: Tests filtering of a document in a disallowed language. - `test_low_confidence`: Tests filtering of a document when language detection confidence is below the threshold. - `test_confident_but_disallowed_language`: Tests filtering when a language is detected with high confidence but is not in the allowed list. - `test_allowed_language_low_confidence`: Tests filtering when an allowed language is detected but with confidence below the threshold. NOTE: Due to limitations in my current environment (Rust 1.75.0), I couldn't run the tests successfully. A transitive dependency (`calendrical_calculations v0.1.3`) requires Rust 1.81 or newer. My attempts to downgrade dependencies were unsuccessful in resolving this core incompatibility. I believe the tests are correct and should pass in an environment with an up-to-date Rust toolchain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a suite of unit tests for the
LanguageDetectionFilterinsrc/pipeline/filters/language_filter.rs.The following test cases have been added:
test_allowed_language: Tests processing of a document in an allowed language.test_disallowed_language: Tests filtering of a document in a disallowed language.test_low_confidence: Tests filtering of a document when language detection confidence is below the threshold.test_confident_but_disallowed_language: Tests filtering when a language is detected with high confidence but is not in the allowed list.test_allowed_language_low_confidence: Tests filtering when an allowed language is detected but with confidence below the threshold.NOTE: Due to limitations in my current environment (Rust 1.75.0), I couldn't run the tests successfully. A transitive dependency (
calendrical_calculations v0.1.3) requires Rust 1.81 or newer. My attempts to downgrade dependencies were unsuccessful in resolving this core incompatibility. I believe the tests are correct and should pass in an environment with an up-to-date Rust toolchain.