ksh -n: Fix spurious warning for --(no)backslashctrl#932
Merged
ksh -n: Fix spurious warning for --(no)backslashctrl#932
Conversation
src/cmd/ksh93/sh/parse.c: simple():
- During noexec, use strmatch() to more precisely identify obsolete
options passed to set(1). This fixes a bug where 'ksh -n' would
falsely flag --nobackslashctrl as obsolete, and also allows for the
detection of other obsolescent options besides just '-k'.
Additionally, do this in a loop to check all of the options passed to
set (rather than just the first option).
- Also check for and warn against the obsolete 'alias -x' (ksh93 has
never supported exported aliases).
src/cmd/ksh93/{data/builtins.c,include/builtins.h,sh/shcomp.c}:
- More clearly document which options to set(1) are obsolete.
- Add SYSALIAS offset macro and use that instead of strcmp.
- Do not compile in usage information for arrowkeysearch or
backslashctrl if the editor modes are not compiled in.
McDutchie
pushed a commit
that referenced
this pull request
Feb 15, 2026
src/cmd/ksh93/sh/parse.c: simple():
- During noexec, use strmatch() to more precisely identify obsolete
options passed to set(1). This fixes a bug where 'ksh -n' would
falsely flag --nobackslashctrl as obsolete, and also allows for
the detection of other obsolescent options besides just '-k'.
Additionally, do this in a loop to check all of the options
passed to set (rather than just the first option).
- Also check for and warn against the obsolete 'alias -x' (ksh93
has never supported exported aliases).
src/cmd/ksh93/{data/builtins.c,include/builtins.h,sh/shcomp.c}:
- More clearly document which options to set(1) are obsolete.
- Add SYSALIAS offset macro and use that instead of strcmp.
- Do not compile in usage information for backslashctrl if the
editor modes are not compiled in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/cmd/ksh93/sh/parse.c:
simple():strmatch()to more precisely identify obsolete options passed to set(1). This fixes a bug whereksh -nwould falsely flag--nobackslashctrlas obsolete, and also allows for the detection of other obsolescent options besides just-k. Additionally, do this in a loop to check all of the options passed to set (rather than just the first option).alias -x(ksh93 has never supported exported aliases).src/cmd/ksh93/{data/builtins.c,include/builtins.h,sh/shcomp.c}:
set(1)are obsolete.SYSALIASoffset macro and use that instead ofstrcmp.arrowkeysearchorbackslashctrlif the editor modes are not compiled in.