Skip to content

Panel: move from left to right#5

Open
vitaly-zdanevich wants to merge 2 commits intokuanyui:masterfrom
vitaly-zdanevich:patch-2
Open

Panel: move from left to right#5
vitaly-zdanevich wants to merge 2 commits intokuanyui:masterfrom
vitaly-zdanevich:patch-2

Conversation

@vitaly-zdanevich
Copy link
Contributor

Because at the left it eats some content.

image

kuanyui and others added 2 commits March 6, 2024 10:21
Because at the left it eats some content.
@kuanyui
Copy link
Owner

kuanyui commented Mar 6, 2024

This cause exactly the same problem for RTL languages users instead. (And me personally also had gotten used to left-side buttons...)

I guess adding an option (<select>, two options: right, left) in options_ui would be better.

@kuanyui
Copy link
Owner

kuanyui commented Mar 7, 2024

And... Do you truely find any page content is "eaten" by SearchEngine toolbar?

Because actually I already did some tricks to prevent <body> from being eaten:

Screenshot_20240308_003029

@vitaly-zdanevich
Copy link
Contributor Author

Currently yes, it eats some page content:
image

@kuanyui
Copy link
Owner

kuanyui commented Mar 8, 2024 via email

@vitaly-zdanevich
Copy link
Contributor Author

I found a similar extension that is not eating the content space:
image

Do you like it?

@kuanyui
Copy link
Owner

kuanyui commented Mar 8, 2024

I found a similar extension that is not eating the content space

Do you like it?

I don't get the meaning of "eating content"... The still eats something, doesn't it?

Because the floating buttons always must occupy some space on page.

@vitaly-zdanevich
Copy link
Contributor Author

Yes, but not a useful part of the page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments