Skip to content

Conversation

@stijnvanhulle
Copy link
Collaborator

Accept accessor functions for params and options in Solid Query plugin to enable reactive tracking.

The generated hooks now accept parameters and options as accessor functions (() => Type) instead of direct values. This allows Solid Query to automatically track changes to reactive primitives (like signals) passed as parameters, enabling automatic refetching without requiring manual createMemo wrappers or other workarounds.


Open in Cursor Open in Web

@cursor
Copy link

cursor bot commented Nov 21, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025

⚠️ No Changeset found

Latest commit: 1c2c135

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kubb-labs-dev
Copy link

kubb-labs-dev bot commented Nov 21, 2025

The preview deployment for kubb-labs/kubb:main is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2025-11-21 14:42:11 CET

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 21, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cursor/create-pr-for-solid-plugin-issue-e979

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 21, 2025

More templates

@kubb/cli

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/cli@2037

@kubb/core

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/core@2037

kubb

npm i https://pkg.pr.new/kubb-labs/kubb@2037

@kubb/mcp

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/mcp@2037

@kubb/oas

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/oas@2037

@kubb/plugin-client

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-client@2037

@kubb/plugin-cypress

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-cypress@2037

@kubb/plugin-faker

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-faker@2037

@kubb/plugin-mcp

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-mcp@2037

@kubb/plugin-msw

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-msw@2037

@kubb/plugin-oas

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-oas@2037

@kubb/plugin-react-query

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-react-query@2037

@kubb/plugin-redoc

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-redoc@2037

@kubb/plugin-solid-query

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-solid-query@2037

@kubb/plugin-svelte-query

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-svelte-query@2037

@kubb/plugin-swr

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-swr@2037

@kubb/plugin-ts

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-ts@2037

@kubb/plugin-vue-query

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-vue-query@2037

@kubb/plugin-zod

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-zod@2037

unplugin-kubb

npm i https://pkg.pr.new/kubb-labs/kubb/unplugin-kubb@2037

commit: 1c2c135

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 86.84211% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.31%. Comparing base (20928c0) to head (1c2c135).

Files with missing lines Patch % Lines
...plugin-solid-query/src/components/QueryOptions.tsx 85.71% 2 Missing and 1 partial ⚠️
...ckages/plugin-solid-query/src/components/Query.tsx 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2037      +/-   ##
==========================================
+ Coverage   80.27%   80.31%   +0.04%     
==========================================
  Files         133      133              
  Lines        4876     4908      +32     
  Branches     2033     2045      +12     
==========================================
+ Hits         3914     3942      +28     
- Misses        868      870       +2     
- Partials       94       96       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants