Repository navigation
Conversation
Add a -default-image-registry operator flag that replaces the registry of the default Fluentd, Fluent Bit, syslog-ng, sidecar and extensions images, for clusters that pull from a private mirror. Images set in the resources are left alone. The chart gets global.registry, which sets the flag and is used for the operator and test receiver images too. Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
Promptless documentation updates
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2253
With a private mirror you currently have to set the repository of every component image in every Logging resource, and some of them like the drain watch or buffer metrics images are easy to miss. This adds a
-default-image-registryoperator flag that swaps the registry of all the default images the operator fills in (Fluentd, Fluent Bit, syslog-ng and their reloader, metrics, drain and volume images, plus the HostTailer, EventTailer and tailer webhook images). Anything a resource sets explicitly is left as is.In the chart,
global.registrysets that flag and is also applied to the operator and test receiver images, so one value covers the whole install. The registry part of an image is replaced (ghcr.io/fluent/fluent-bitbecomesmirror.example.com/fluent/fluent-bit), and an image without one gets the registry added in front.I added tests for the registry replacement and for SetDefaults with a registry set, regenerated the chart README, and checked
helm templatewith and withoutglobal.registry.