Repository navigation
Conversation
…enabled Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
Promptless documentation updates
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
fluentd.tls.enabledset, CreateSystem swappedforwardInputConfig.transportfor a hardcoded block, so any ciphers, version or protocol the user set on the forward listener were silently dropped. It also wrote that block straight into the user's spec object.Now the operator works on a copy of the forward input config, only forces the cert paths and client_cert_auth, keeps everything else from the user's transport, and falls back to TLSv1_2 only when no version is set. I pulled that logic into a small helper and added a table test for it.
I checked the other TLS spots (fluentd statefulset/configcheck, fluent bit, syslog-ng) and they only mount the secret, so this was the only place with the overwrite.
Fixes #2380