Skip to content

Conversation

@EnableAsync
Copy link

issue: #114

@kubeedge-bot
Copy link
Collaborator

Welcome @EnableAsync! It looks like this is your first PR to kubeedge/examples 🎉

@kubeedge-bot kubeedge-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 5, 2022
Copy link

@RyanZhaoXB RyanZhaoXB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. it seems that the vendor folder should be deprecated.

@kubeedge-bot
Copy link
Collaborator

@RyanZhaoXB: changing LGTM is restricted to collaborators

In response to this:

lgtm. it seems that the vendor folder should be deprecated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RyanZhaoXB
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RyanZhaoXB
Copy link

@fisherxu please help to review this pr. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants