test: Drain tool E2Es, UTs #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvind Thirumurugan <[email protected]>
Arvindthiru
force-pushed
the
drain-tool-test
branch
from
1e1c2b5 to
4a9fc2a
Compare
Signed-off-by: Arvind Thirumurugan <[email protected]>
michaelawyu
reviewed
Apr 23, 2025
Collaborator
michaelawyu
left a comment
michaelawyu
left a comment
There was a problem hiding this comment.
Just 2 files left for review; apologies for the delay.
michaelawyu
reviewed
Apr 23, 2025
Collaborator
michaelawyu
left a comment
michaelawyu
left a comment
There was a problem hiding this comment.
Added a few comments, PTAL. Otherwise LGTM ;) And apologies for the delay 😞
Signed-off-by: Arvind Thirumurugan <[email protected]>
michaelawyu
reviewed
Apr 30, 2025
Collaborator
michaelawyu
left a comment
michaelawyu
left a comment
There was a problem hiding this comment.
A few minor issues; otherwise LGTM.
Signed-off-by: Arvind Thirumurugan <[email protected]>
Arvindthiru
force-pushed
the
drain-tool-test
branch
from
25fba24 to
1b4a90b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
audrastump
pushed a commit
to audrastump/kubefleet
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer