-
Notifications
You must be signed in to change notification settings - Fork 20
docs: improve the kubeFleet landing page and add community meeting info #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve the kubeFleet landing page and add community meeting info #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Enhance the KubeFleet README by reorganizing introductory content, adding quickstart and community meeting details, and updating links and badges.
- Introduce a “What is KubeFleet?” section and refine the project overview.
- Add Quickstart instructions and Community sections including bi-weekly meeting information.
- Update badge URLs to point at the correct
kubefleet-dev/kubefleetrepository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Enhance the README with a clearer project introduction, updated community links, and added community meeting details
- Introduce “What is KubeFleet?”, Quickstart, and Documentation sections
- Add Community and Community Meetings information with calendar and recordings links
- Update repository badges and consolidate Code of Conduct section
84cfa1d to
e1ba1e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the KubeFleet landing page documentation by adding detailed community and meeting information, and it refines error handling for concurrent updateRuns in the updaterun controller.
- Enhanced error handling in pkg/controllers/updaterun/execution.go to better address concurrency issues.
- Updated README.md to provide clearer information about KubeFleet features and added links for community engagement.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/controllers/updaterun/execution.go | Refactored error handling logic for concurrent updateRuns with improved logging and variable usage. |
| README.md | Revised landing page content and added community meeting info, with updated link references. |
Comments suppressed due to low confidence (1)
pkg/controllers/updaterun/execution.go:178
- Consider including the updateRun identifier or additional context in the error message to more clearly indicate the cause of preemption due to concurrent updates, which can help in debugging.
preemptedErr := controller.NewUserError(fmt.Errorf("the clusterResourceBinding of the updating cluster `%s` in the stage `%s` is not up-to-date with the desired status, please check the status of binding `%s` and see if there is a concurrent updateRun referencing the same clusterResourcePlacement and updating the same cluster", clusterStatus.ClusterName, updatingStageStatus.StageName, klog.KObj(binding)))
README.md
Outdated
| You can reach the KubeFleet community and developers via the following channels: | ||
|
|
||
| * Q & A: [Github Discussions](https://github.com/kubefleet-dev/kubefleet/discussions) | ||
| * Slack: [The #KubeFleet Slack channel] (https://cloud-native.slack.com/archives/C08KR7589R8) |
Copilot
AI
May 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the extra space between the closing bracket and the opening parenthesis in the Slack link so that the markdown renders correctly.
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
8587ac6 to
cea8e1d
Compare
README.md
Outdated
|
|
||
| ## Documentation | ||
|
|
||
| To learn more about KubeFleet go to the [the KubeFleet documentation](https://kubefleet-dev.github.io/website/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ryan! I think the duplicate the issue re-appears somehow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same to a lot of the raised issues... Is there something wrong on my end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, do you see more duplicates?
Signed-off-by: michaelawyu <[email protected]> Signed-off-by: Ryan Zhang <[email protected]> Co-authored-by: Ryan Zhang <[email protected]> Signed-off-by: Ryan Zhang <[email protected]>
…ate (kubefleet-dev#63) Signed-off-by: Ryan Zhang <[email protected]>
Signed-off-by: Ryan Zhang <[email protected]>
Signed-off-by: Ryan Zhang <[email protected]>
Signed-off-by: Ryan Zhang <[email protected]>
…et-dev#61) Signed-off-by: Ryan Zhang <[email protected]>
Signed-off-by: Ryan Zhang <[email protected]>
Co-authored-by: Copilot <[email protected]> Co-authored-by: Britania Rodriguez Reyes <[email protected]> Signed-off-by: Ryan Zhang <[email protected]>
b7f3d59 to
f7be0f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Improve the KubeFleet README by restructuring key sections, updating badge links, and adding community meeting information.
- Restructured landing page sections (What is KubeFleet, Quickstart, Documentation, Community, Meetings)
- Added bi-weekly community meeting details and relevant links
- Updated repository references for badges
Comments suppressed due to low confidence (1)
README.md:58
- The Codecov badge still references
Azure/fleet; update it tokubefleet-dev/kubefleetso it points to the current repository.
[4]: https://codecov.io/gh/Azure/fleet/branch/main/graph/badge.svg?token=D3mtbzACjC
| You can reach the KubeFleet community and developers via the following channels: | ||
|
|
||
| * Q & A: [GitHub Discussions](https://github.com/kubefleet-dev/kubefleet/discussions) | ||
| * Slack: [The #KubeFleet Slack channel](https://cloud-native.slack.com/archives/C08KR7589R8) |
Copilot
AI
May 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The Slack link points to an internal workspace; consider providing the public join link (e.g., via slack.cncf.io) or instructions so new contributors can easily join.
| * Slack: [The #KubeFleet Slack channel](https://cloud-native.slack.com/archives/C08KR7589R8) | |
| * Slack: Join the [KubeFleet Slack workspace](https://slack.cncf.io) and navigate to the `#KubeFleet` channel to connect with the community. |
|
|
||
| * Q & A: [GitHub Discussions](https://github.com/kubefleet-dev/kubefleet/discussions) | ||
| * Slack: [The #KubeFleet Slack channel](https://cloud-native.slack.com/archives/C08KR7589R8) | ||
| * Mailing list: [mailing list](https://groups.google.com/g/kubefleet-dev) |
Copilot
AI
May 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The link text 'mailing list' is generic; consider changing it to 'KubeFleet mailing list' to make the purpose clear at first glance.
| * Mailing list: [mailing list](https://groups.google.com/g/kubefleet-dev) | |
| * Mailing list: [KubeFleet mailing list](https://groups.google.com/g/kubefleet-dev) |
Description of your changes
improve the kubeFleet landing page and add community meeting info.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer