feat: add the resource placement related API #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanzhang-oss
force-pushed
the
resource-placement-api
branch
from
86110a9 to
88caf94
Compare
Signed-off-by: Ryan Zhang <[email protected]>
ryanzhang-oss
force-pushed
the
resource-placement-api
branch
from
88caf94 to
6c54711
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the namespaced resource placement API types while renaming several ClusterResourcePlacement-related types to more generic Placement types. Key changes include the renaming of specifications and statuses from ClusterResourcePlacementSpec/Status to PlacementSpec/Status across controllers and tests, updates to CRD YAML files to reflect new labels and naming conventions, and modifications to API types and their deepcopy functions.
Reviewed Changes
Copilot reviewed 56 out of 56 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/controllers/clusterresourceplacementwatcher/watcher_integration_test.go | Renames resource spec type to PlacementSpec in test setup. |
| pkg/controllers/clusterresourceplacementeviction/* | Updates spec type to PlacementSpec in multiple test cases. |
| pkg/controllers/clusterresourceplacement/placement_status_test.go | Adjusts status type from ClusterResourcePlacementStatus to PlacementStatus. |
| pkg/controllers/clusterresourceplacement/* | Applies similar renaming in controller tests and integration tests. |
| config/crd/bases/* | Updates CRD definitions to use new labels (e.g. PlacementTrackingLabel) and removes redundant comments. |
| apis/placement/v1beta1/* | Renames API type fields and updates deepcopy functions and comments to reflect the new Placement API, as well as adjusting comments regarding tracking labels. |
| .github/.copilot/breadcrumbs/* | Documentation update that details the implementation and registration of new namespace-scoped types. |
Comments suppressed due to low confidence (1)
pkg/controllers/clusterresourceplacementeviction/controller_intergration_test.go:0
- Consider renaming the file to 'controller_integration_test.go' to correct the spelling of 'integration'.
controller_intergration_test.go
circy9
reviewed
May 31, 2025
Signed-off-by: Ryan Zhang <[email protected]>
circy9
approved these changes
May 31, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
This was referenced Jun 4, 2025
audrastump
pushed a commit
to audrastump/kubefleet
that referenced
this pull request
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add the namespaced resource placement API with some rename
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer