Fix: Prevent duplicate sidecars by copying to temp before sed modifications

[kaovilai]

Description

Fixes #620

This PR prevents the duplicate container bug that occurs when running SNAPSHOT_METADATA_TESTS=true ./deploy.sh or VOLUME_MODE_CONVERSION_TESTS=true ./deploy.sh multiple times.

Problem

The deployment script was using sed -i to modify git-tracked YAML files in-place. Each run would add more sidecars, causing:

• Run 1: ✅ Works (1 sidecar)
• Run 2: ❌ Duplicate containers (2 sidecars)
• Run 3+: ❌ More duplicates → Kubernetes rejects deployment

Solution

Copy files to ${TEMP_DIR} before applying sed modifications:

# Copy to temp first
temp_yaml="${TEMP_DIR}/$(basename "$i")"
cp "$i" "$temp_yaml"

# Apply sed -i to temp copy (not original)
sed -i -e "/# end csi containers/r ${PATCH_FILE}" "$temp_yaml"

This keeps original files pristine and makes the script fully idempotent.

Changes

• Modified deploy/util/deploy-hostpath.sh lines 257-270
• All deploy/kubernetes-*/deploy.sh symlinks benefit from this fix

Testing

The script can now be run multiple times without creating duplicate containers. Original git-tracked files remain unchanged.

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes deployment script to copy YAML files to temp directory before modifications, preventing duplicate sidecars on subsequent runs.

Which issue(s) this PR fixes:

Fixes #620

Special notes for your reviewer:

The fix is simple: copy files to ${TEMP_DIR} before running sed -i, keeping the same sed syntax but operating on temporary copies instead of git-tracked files.

Does this PR introduce a user-facing change?:

Fixed deployment script to prevent duplicate sidecars when running with SNAPSHOT_METADATA_TESTS=true or VOLUME_MODE_CONVERSION_TESTS=true multiple times

Note

Responses generated with Claude

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kaovilai
Once this PR has been reviewed and has the lgtm label, please assign saad-ali for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @kaovilai!

It looks like this is your first PR to kubernetes-csi/csi-driver-host-path 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-host-path has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @kaovilai. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[carlory]

/ok-to-test