Skip to content

Conversation

@ElijahQuinones
Copy link
Member

Is this a bug fix or adding new feature?
Nether
What is this PR about? / Why do we need it?
This PR updates the timeout of the snapshot-controller side car to be 60s to conform to the timeouts of the other sidecars set in PR 1824
What testing is done?
CI

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from elijahquinones. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 29, 2024
@github-actions
Copy link

Code Coverage Diff

This PR does not change the code coverage

@ElijahQuinones
Copy link
Member Author

/retest

Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just use the default value? back in the day, we decided not to set this value because the external snapshotter already has a 60s timeout value.

The default timeout value for other sidecars is much lower:

  • volume-modifier: 10s
  • resizer: 10s
  • attacher: 15s

@ElijahQuinones
Copy link
Member Author

ElijahQuinones commented Oct 30, 2024

Can we just use the default value? back in the day, we decided not to set this value because the external snapshotter already has a 60s timeout value.

The default timeout value for other sidecars is much lower:

  • volume-modifier: 10s
  • resizer: 10s
  • attacher: 15s

Ahh I was not aware that the default was 60 seconds I agree then we can just keep default as it is the same as other sidecars. Thanks Eddie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants