-
Notifications
You must be signed in to change notification settings - Fork 849
Fix action in clone volumes documentation #2758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix action in clone volumes documentation #2758
Conversation
|
|
|
Hi @benbz. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ConnorJC3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
LGTM pending CLA
Code Coverage DiffThis PR does not change the code coverage |
|
CLA has been signed without too much fuss on my side 🎉 |
torredil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @benbz.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What is this PR about? / Why do we need it?
Split out of #2756. #2716 added volume cloning functionality and updated the IAM policy in various places. When comparing
hack/e2e/kops/patch-cluster.yamlanddocs/install.mdit was also noticed that one of the Actions was incorrect indocs/install.mdand should have beenec2:CreateTagsHow was this change tested?
n/a
Does this PR introduce a user-facing change?