-
Notifications
You must be signed in to change notification settings - Fork 849
cmd: handle --version before metadata initialization
#2776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
cmd: handle --version before metadata initialization
#2776
Conversation
Print the version and exit before any cloud or metadata setup so that invoking '--version' doesn't attempt IMDS or in-cluster Kubernetes API calls. Previously those initialization attempts could time out or fail in CI, local, or isolated build environments and cause '--version' to return a non-zero status. Normal startup behavior is unchanged when '--version' is not used. Signed-off-by: Debasish Biswas <[email protected]>
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @debasishbsws! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @debasishbsws. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
@debasishbsws: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind bug
What is this PR about? / Why do we need it?
Current behavior :
Print the version and exit before any cloud or metadata setup so that invoking '--version' doesn't attempt IMDS or in-cluster Kubernetes API calls. Previously those initialization attempts could time out or fail in CI, local, or isolated build environments and cause '--version' to return a non-zero status.
Normal startup behavior is unchanged when '--version' is not used.