Skip to content

Conversation

@wweiwei-li
Copy link
Collaborator

Issue

#4517

Description

Issue: The globalaccelerators.aga.k8s.aws CRD is duplicated in the Helm chart

Included in crds.yaml
Also listed separately in aga-crds.yaml
Both referenced in crds/kustomization.yaml
Impact:
✅ Direct Helm users: No impact - helm install and helm upgrade work normally.
❌ Kustomize/ArgoCD users with includeCRDs: true : Deployment fails with duplicate resource error.

This fix is to remove aga-crds.yaml from kustomization.yaml
-->

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wweiwei-li

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 22, 2025
@wweiwei-li wweiwei-li requested review from shraddhabang and removed request for shuqz and zac-nixon December 22, 2025 22:56
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 22, 2025
$(KUSTOMIZE) build config/crd/aga > config/crd/aga/aga-crds.yaml
echo '---' > config/crd/aga/aga-crds.yaml
$(KUSTOMIZE) build config/crd/aga >> config/crd/aga/aga-crds.yaml
$(COPY_AGA_CRDS_TO_HELM)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have

	$(KUSTOMIZE) build config/crd/gateway > config/crd/gateway/gateway-crds.yaml
	echo '---' > config/crd/gateway/gateway-crds.yaml
	$(KUSTOMIZE) build config/crd/gateway >> config/crd/gateway/gateway-crds.yaml
$(COPY_GATEWAY_CRDS_TO_HELM)

for gateway api because we want to separate out gateway api crds into its own directory. now since want to consider aga at same level as bases, i am wondering should we move aga crd definitions to /bases instead of /aga

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good question. I was debating. but I am thinking just keep it as it is, so it is in separate/aga for organization, but included by default in https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/config/crd/kustomization.yaml (like bases)

resources:
  - bases/elbv2.k8s.aws_targetgroupbindings.yaml
  - bases/elbv2.k8s.aws_ingressclassparams.yaml
  - bases/elbv2.k8s.aws_albtargetcontrolconfigs.yaml
  - aga/aga-crds.yaml

@shraddhabang
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 29, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9410489 into kubernetes-sigs:main Dec 29, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants