Skip to content

Conversation

@dabradley
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 5, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2025
@dabradley dabradley removed the request for review from andyzhangx March 5, 2025 18:33
@dabradley dabradley marked this pull request as draft March 12, 2025 13:02
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2025
@dabradley dabradley force-pushed the personal/dabradley/dynprov branch from 0f28a9c to 56dd8a9 Compare March 13, 2025 12:57
@dabradley dabradley changed the base branch from development to dynamic-provisioning-preview March 13, 2025 13:02
@dabradley dabradley self-assigned this Mar 13, 2025
@dabradley
Copy link
Collaborator Author

/retest

@dabradley dabradley force-pushed the personal/dabradley/dynprov branch from 56dd8a9 to a4abd62 Compare March 13, 2025 15:06
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dabradley, t-mialve

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dabradley dabradley force-pushed the dynamic-provisioning-preview branch from 442f435 to 08c5e8d Compare March 13, 2025 15:08
@dabradley dabradley marked this pull request as ready for review March 13, 2025 15:10
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2025
@dabradley dabradley force-pushed the personal/dabradley/dynprov branch 2 times, most recently from 4b16ca3 to 40a6ecb Compare March 14, 2025 19:08
@csmuell
Copy link
Contributor

csmuell commented Mar 14, 2025

Discussed offline - LGTM.

@dabradley dabradley force-pushed the personal/dabradley/dynprov branch from 40a6ecb to 0b1d3f8 Compare March 14, 2025 19:14
@dabradley dabradley merged commit f3b8b89 into kubernetes-sigs:dynamic-provisioning-preview Mar 15, 2025
6 of 7 checks passed
@dabradley dabradley deleted the personal/dabradley/dynprov branch August 6, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants