Add startup taint removal functionality to azurelustre CSI driver #232
+606
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
approved
Pull Request Test Coverage Report for Build 18750002860Details
💛 - Coveralls |
k8s-ci-robot
added
size/XXL
dabradley
force-pushed
the
add-startup-taint
branch
2 times, most recently
from
541f35e to
fb3a961
Compare
k8s-ci-robot
added
size/XL
dabradley
force-pushed
the
add-startup-taint
branch
from
fb3a961 to
3abbd56
Compare
Since the same description applies to both types of install, we only need this once. This aligns it better with the taint description as well.
dabradley
force-pushed
the
add-startup-taint
branch
from
3abbd56 to
f7eff04
Compare
The taint key follows the pattern: {driverName}/agent-not-ready
e.g., azurelustre.csi.azure.com/agent-not-ready
This allows users to apply startup taints to prevent scheduling before the CSI driver is ready,
addressing potential race conditions during node startup.
dabradley
force-pushed
the
add-startup-taint
branch
from
f7eff04 to
316612a
Compare
|
@dabradley Moving our conversation here, still keen on testing these changes! I've run into some roadblocks with our product security guys, they are not excited about running images in our dev environment that aren't built using our own, or an external "official" build system. By any chance, do you have a public build available with these changes available to test? If not, I'll see what else I can do to get the wheels moving on my end :) Thanks! |
t-mialve
reviewed
Oct 22, 2025
t-mialve
reviewed
Oct 22, 2025
dabradley
force-pushed
the
add-startup-taint
branch
from
316612a to
63de64f
Compare
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dabradley, t-mialve The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The taint key follows the pattern: {driverName}/agent-not-ready e.g., azurelustre.csi.azure.com/agent-not-ready
This allows users to apply startup taints to prevent scheduling before the CSI driver is ready, addressing potential race conditions during node startup.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #216
Requirements:
Special notes for your reviewer:
Release note: