-
Notifications
You must be signed in to change notification settings - Fork 304
✨ Support Node Auto Placement and Node AF/AAF #3655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zhanggbj
wants to merge
16
commits into
kubernetes-sigs:main
Choose a base branch
from
zhanggbj:node_auto_placement
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,728
−37
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
fa60556
Bump VMOP and add NodeAutoPlacement Feature Gate
zhanggbj b52056f
Add VMG controller of node auto placement
zhanggbj 72fad61
Updates logic for VMG creation
srm09 124623a
Initial impl for VSphereMachine AAF changes
srm09 9f261d5
Removes cluster-name label from affinity rules
srm09 22d7db0
Selectively add node-pool AAF constraint
srm09 8474942
Refine VMG controller when generate per-MD zone labels (#71)
zhanggbj 833cdb5
Sync VSphereMachines in VMG controller
zhanggbj 36c3550
Add VMG reconciler unit test and bump VMOP
zhanggbj 189f6d2
Surface error when VM is waiting for VMG
zhanggbj 8cc8e8a
Update dependency in packaging&test
zhanggbj 2a21acc
Fix UT errors
zhanggbj 947dffa
Fix annotations
zhanggbj 5847119
Fix vmg UT errors
zhanggbj e3078c9
Refine VMG controller
zhanggbj bab7415
Address review comments
zhanggbj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| /* | ||
| Copyright 2025 The Kubernetes Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package vmware | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| vmoprv1 "github.com/vmware-tanzu/vm-operator/api/v1alpha2" | ||
| apitypes "k8s.io/apimachinery/pkg/types" | ||
| clusterv1 "sigs.k8s.io/cluster-api/api/core/v1beta2" | ||
| "sigs.k8s.io/cluster-api/util/predicates" | ||
| ctrl "sigs.k8s.io/controller-runtime" | ||
| ctrlbldr "sigs.k8s.io/controller-runtime/pkg/builder" | ||
| ctrlclient "sigs.k8s.io/controller-runtime/pkg/client" | ||
| "sigs.k8s.io/controller-runtime/pkg/controller" | ||
| "sigs.k8s.io/controller-runtime/pkg/event" | ||
| "sigs.k8s.io/controller-runtime/pkg/handler" | ||
| "sigs.k8s.io/controller-runtime/pkg/manager" | ||
| "sigs.k8s.io/controller-runtime/pkg/predicate" | ||
| "sigs.k8s.io/controller-runtime/pkg/reconcile" | ||
|
|
||
| vmwarev1 "sigs.k8s.io/cluster-api-provider-vsphere/apis/vmware/v1beta1" | ||
| capvcontext "sigs.k8s.io/cluster-api-provider-vsphere/pkg/context" | ||
| ) | ||
|
|
||
| // +kubebuilder:rbac:groups=cluster.x-k8s.io,resources=clusters,verbs=get;list;watch | ||
| // +kubebuilder:rbac:groups=cluster.x-k8s.io,resources=clusters/status,verbs=get | ||
| // +kubebuilder:rbac:groups=vmoperator.vmware.com,resources=virtualmachinegroups,verbs=get;list;watch;create;update;patch;delete | ||
| // +kubebuilder:rbac:groups=vmoperator.vmware.com,resources=virtualmachinegroups/status,verbs=get;list;watch;create;update;patch;delete | ||
| // +kubebuilder:rbac:groups=vmware.infrastructure.cluster.x-k8s.io,resources=vspheremachines,verbs=get;list;watch | ||
| // +kubebuilder:rbac:groups=cluster.x-k8s.io,resources=machinedeployments,verbs=get;list;watch | ||
| // +kubebuilder:rbac:groups=cluster.x-k8s.io,resources=machines,verbs=get;list;watch | ||
|
|
||
| // AddVirtualMachineGroupControllerToManager adds the VirtualMachineGroup controller to the provided manager. | ||
| func AddVirtualMachineGroupControllerToManager(ctx context.Context, controllerManagerCtx *capvcontext.ControllerManagerContext, mgr manager.Manager, options controller.Options) error { | ||
| predicateLog := ctrl.LoggerFrom(ctx).WithValues("controller", "virtualmachinegroup") | ||
|
|
||
| reconciler := &VirtualMachineGroupReconciler{ | ||
| Client: controllerManagerCtx.Client, | ||
| Recorder: mgr.GetEventRecorderFor("virtualmachinegroup-controller"), | ||
| } | ||
|
|
||
| builder := ctrl.NewControllerManagedBy(mgr). | ||
| For(&clusterv1.Cluster{}). | ||
| WithOptions(options). | ||
| // Set the controller's name explicitly to virtualmachinegroup. | ||
| Named("virtualmachinegroup"). | ||
| Watches( | ||
| &vmoprv1.VirtualMachineGroup{}, | ||
| handler.EnqueueRequestForOwner(mgr.GetScheme(), reconciler.Client.RESTMapper(), &clusterv1.Cluster{}), | ||
| ctrlbldr.WithPredicates(predicates.ResourceIsChanged(mgr.GetScheme(), predicateLog)), | ||
| ). | ||
| Watches( | ||
| &vmwarev1.VSphereMachine{}, | ||
| handler.EnqueueRequestsFromMapFunc(reconciler.VSphereMachineToCluster), | ||
| ctrlbldr.WithPredicates( | ||
| predicate.Funcs{ | ||
| UpdateFunc: func(event.UpdateEvent) bool { return false }, | ||
| CreateFunc: func(e event.CreateEvent) bool { | ||
| // Only handle VSphereMachine which belongs to a MachineDeployment | ||
| _, found := e.Object.GetLabels()[clusterv1.MachineDeploymentNameLabel] | ||
| return found | ||
| }, | ||
| DeleteFunc: func(e event.DeleteEvent) bool { | ||
| // Only handle VSphereMachine which belongs to a MachineDeployment | ||
| _, found := e.Object.GetLabels()[clusterv1.MachineDeploymentNameLabel] | ||
| return found | ||
| }, | ||
| GenericFunc: func(event.GenericEvent) bool { return false }, | ||
| }), | ||
| ). | ||
| WithEventFilter(predicates.ResourceHasFilterLabel(mgr.GetScheme(), predicateLog, controllerManagerCtx.WatchFilterValue)) | ||
|
|
||
| return builder.Complete(reconciler) | ||
| } | ||
|
|
||
| // VSphereMachineToCluster maps VSphereMachine events to Cluster reconcile requests. | ||
| func (r *VirtualMachineGroupReconciler) VSphereMachineToCluster(_ context.Context, a ctrlclient.Object) []reconcile.Request { | ||
| vSphereMachine, ok := a.(*vmwarev1.VSphereMachine) | ||
| if !ok { | ||
| return nil | ||
| } | ||
|
|
||
| clusterName, ok := vSphereMachine.Labels[clusterv1.ClusterNameLabel] | ||
| if !ok || clusterName == "" { | ||
| return nil | ||
| } | ||
|
|
||
| return []reconcile.Request{{ | ||
| NamespacedName: apitypes.NamespacedName{ | ||
| Namespace: vSphereMachine.Namespace, | ||
| Name: clusterName, | ||
| }, | ||
| }} | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have not been using this in CAPV up until now, but let's use it here to already improve this new reconciler (I have a task to follow-up for others soon'ish).
Per default the reconciler will get resyncs from all informers. i.e. every 10m everything gets reconciled because of the Cluster resync and additionally every 10m everything gets reconciled because of the VirtualMachineGroup resync.
In core CAPI we drop events from resyncs of secondary watches to avoid this issue
(it's not needed for VSphereMachine below as we already drop all updates)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. This help to reduce the resync noices.