-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 Bump the all-go-mod-patch-and-minor group across 3 directories with 12 updates #11973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump the all-go-mod-patch-and-minor group across 3 directories with 12 updates #11973
Conversation
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| github.com/google/uuid v1.6.0 // indirect | ||
| github.com/gorilla/websocket v1.5.3 // indirect | ||
| github.com/grpc-ecosystem/grpc-gateway/v2 v2.20.0 // indirect | ||
| github.com/hashicorp/hcl v1.0.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Viper got rid of hcl, so now we can get rid of hcl (hcl was not great from a licensing perspective): #9181
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally 👍
… 12 updates Bumps the all-go-mod-patch-and-minor group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | [github.com/spf13/viper](https://github.com/spf13/viper) | `1.19.0` | `1.20.0` | | [k8s.io/api](https://github.com/kubernetes/api) | `0.32.2` | `0.32.3` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.32.2` | `0.32.3` | | [k8s.io/cluster-bootstrap](https://github.com/kubernetes/cluster-bootstrap) | `0.32.2` | `0.32.3` | | [golang.org/x/net](https://github.com/golang/net) | `0.36.0` | `0.37.0` | Bumps the all-go-mod-patch-and-minor group with 6 updates in the /hack/tools directory: | Package | From | To | | --- | --- | --- | | [github.com/spf13/viper](https://github.com/spf13/viper) | `1.19.0` | `1.20.0` | | [k8s.io/api](https://github.com/kubernetes/api) | `0.32.2` | `0.32.3` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.32.2` | `0.32.3` | | [k8s.io/cluster-bootstrap](https://github.com/kubernetes/cluster-bootstrap) | `0.32.2` | `0.32.3` | | [cloud.google.com/go/storage](https://github.com/googleapis/google-cloud-go) | `1.50.0` | `1.51.0` | | [google.golang.org/api](https://github.com/googleapis/google-api-go-client) | `0.224.0` | `0.226.0` | Bumps the all-go-mod-patch-and-minor group with 5 updates in the /test directory: | Package | From | To | | --- | --- | --- | | [github.com/spf13/viper](https://github.com/spf13/viper) | `1.19.0` | `1.20.0` | | [k8s.io/api](https://github.com/kubernetes/api) | `0.32.2` | `0.32.3` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.32.2` | `0.32.3` | | [k8s.io/cluster-bootstrap](https://github.com/kubernetes/cluster-bootstrap) | `0.32.2` | `0.32.3` | | [golang.org/x/net](https://github.com/golang/net) | `0.36.0` | `0.37.0` | Updates `github.com/spf13/viper` from 1.19.0 to 1.20.0 - [Release notes](https://github.com/spf13/viper/releases) - [Commits](spf13/viper@v1.19.0...v1.20.0) Updates `google.golang.org/grpc` from 1.65.1 to 1.67.3 - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.65.1...v1.67.3) Updates `k8s.io/api` from 0.32.2 to 0.32.3 - [Commits](kubernetes/api@v0.32.2...v0.32.3) Updates `k8s.io/apiextensions-apiserver` from 0.32.2 to 0.32.3 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.32.2...v0.32.3) Updates `k8s.io/apimachinery` from 0.32.2 to 0.32.3 - [Commits](kubernetes/apimachinery@v0.32.2...v0.32.3) Updates `k8s.io/apiserver` from 0.32.2 to 0.32.3 - [Commits](kubernetes/apiserver@v0.32.2...v0.32.3) Updates `k8s.io/client-go` from 0.32.2 to 0.32.3 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.32.2...v0.32.3) Updates `k8s.io/cluster-bootstrap` from 0.32.2 to 0.32.3 - [Commits](kubernetes/cluster-bootstrap@v0.32.2...v0.32.3) Updates `k8s.io/component-base` from 0.32.2 to 0.32.3 - [Commits](kubernetes/component-base@v0.32.2...v0.32.3) Updates `golang.org/x/net` from 0.36.0 to 0.37.0 - [Commits](golang/net@v0.36.0...v0.37.0) Updates `github.com/spf13/viper` from 1.19.0 to 1.20.0 - [Release notes](https://github.com/spf13/viper/releases) - [Commits](spf13/viper@v1.19.0...v1.20.0) Updates `k8s.io/api` from 0.32.2 to 0.32.3 - [Commits](kubernetes/api@v0.32.2...v0.32.3) Updates `k8s.io/apiextensions-apiserver` from 0.32.2 to 0.32.3 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.32.2...v0.32.3) Updates `k8s.io/apimachinery` from 0.32.2 to 0.32.3 - [Commits](kubernetes/apimachinery@v0.32.2...v0.32.3) Updates `k8s.io/apiserver` from 0.32.2 to 0.32.3 - [Commits](kubernetes/apiserver@v0.32.2...v0.32.3) Updates `k8s.io/client-go` from 0.32.2 to 0.32.3 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.32.2...v0.32.3) Updates `k8s.io/cluster-bootstrap` from 0.32.2 to 0.32.3 - [Commits](kubernetes/cluster-bootstrap@v0.32.2...v0.32.3) Updates `k8s.io/component-base` from 0.32.2 to 0.32.3 - [Commits](kubernetes/component-base@v0.32.2...v0.32.3) Updates `cloud.google.com/go/storage` from 1.50.0 to 1.51.0 - [Release notes](https://github.com/googleapis/google-cloud-go/releases) - [Changelog](https://github.com/googleapis/google-cloud-go/blob/main/CHANGES.md) - [Commits](googleapis/google-cloud-go@spanner/v1.50.0...spanner/v1.51.0) Updates `google.golang.org/api` from 0.224.0 to 0.226.0 - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.224.0...v0.226.0) Updates `google.golang.org/grpc` from 1.70.0 to 1.71.0 - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.65.1...v1.67.3) Updates `github.com/spf13/viper` from 1.19.0 to 1.20.0 - [Release notes](https://github.com/spf13/viper/releases) - [Commits](spf13/viper@v1.19.0...v1.20.0) Updates `google.golang.org/grpc` from 1.65.1 to 1.67.3 - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.65.1...v1.67.3) Updates `k8s.io/api` from 0.32.2 to 0.32.3 - [Commits](kubernetes/api@v0.32.2...v0.32.3) Updates `k8s.io/apiextensions-apiserver` from 0.32.2 to 0.32.3 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.32.2...v0.32.3) Updates `k8s.io/apimachinery` from 0.32.2 to 0.32.3 - [Commits](kubernetes/apimachinery@v0.32.2...v0.32.3) Updates `k8s.io/apiserver` from 0.32.2 to 0.32.3 - [Commits](kubernetes/apiserver@v0.32.2...v0.32.3) Updates `k8s.io/client-go` from 0.32.2 to 0.32.3 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.32.2...v0.32.3) Updates `k8s.io/cluster-bootstrap` from 0.32.2 to 0.32.3 - [Commits](kubernetes/cluster-bootstrap@v0.32.2...v0.32.3) Updates `k8s.io/component-base` from 0.32.2 to 0.32.3 - [Commits](kubernetes/component-base@v0.32.2...v0.32.3) Updates `golang.org/x/net` from 0.36.0 to 0.37.0 - [Commits](golang/net@v0.36.0...v0.37.0) --- updated-dependencies: - dependency-name: github.com/spf13/viper dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-go-mod-patch-and-minor - dependency-name: k8s.io/apiextensions-apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-go-mod-patch-and-minor - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-go-mod-patch-and-minor - dependency-name: k8s.io/apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-go-mod-patch-and-minor - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-go-mod-patch-and-minor - dependency-name: k8s.io/cluster-bootstrap dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-go-mod-patch-and-minor - dependency-name: k8s.io/component-base dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-go-mod-patch-and-minor - dependency-name: golang.org/x/net dependency-type: indirect update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor - dependency-name: github.com/spf13/viper dependency-type: indirect update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-go-mod-patch-and-minor - dependency-name: k8s.io/apiextensions-apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-go-mod-patch-and-minor - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-go-mod-patch-and-minor - dependency-name: k8s.io/apiserver dependency-type: indirect update-type: version-update:semver-patch dependency-group: all-go-mod-patch-and-minor - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-go-mod-patch-and-minor - dependency-name: k8s.io/cluster-bootstrap dependency-type: indirect update-type: version-update:semver-patch dependency-group: all-go-mod-patch-and-minor - dependency-name: k8s.io/component-base dependency-type: indirect update-type: version-update:semver-patch dependency-group: all-go-mod-patch-and-minor - dependency-name: cloud.google.com/go/storage dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor - dependency-name: google.golang.org/grpc dependency-type: indirect update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor - dependency-name: github.com/spf13/viper dependency-type: indirect update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-go-mod-patch-and-minor - dependency-name: k8s.io/apiextensions-apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-go-mod-patch-and-minor - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-go-mod-patch-and-minor - dependency-name: k8s.io/apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-go-mod-patch-and-minor - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-go-mod-patch-and-minor - dependency-name: k8s.io/cluster-bootstrap dependency-type: indirect update-type: version-update:semver-patch dependency-group: all-go-mod-patch-and-minor - dependency-name: k8s.io/component-base dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-go-mod-patch-and-minor - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-go-mod-patch-and-minor ... Signed-off-by: dependabot[bot] <[email protected]>
c7d5bbe to
4d56937
Compare
|
dependabot would have set go toolchain to 1.24.1, so I had to get rid of it manually. Don't have time to investigate if there is a way that we can avoid that, let's keep an eye on it /lgtm /assign @chrischdi @fabriziopandini |
|
LGTM label has been added. Git tree hash: 2ae6e1c6eae8c53a5c85826cc4976c78afd93e3d
|
Go toolchain directive has been hot topic for long time in Go community: golang/go#65847 |
|
I'm mostly surprised that dependabot started to add it like 1-2 days ago. Wondering what changed |
Yeah noticing the same in Metal3, all of the dependabot bumps have it. But we have had plenty of these before as well tho. I'm suspecting the x/net related vulnerability fix from last week, as that basically made every repo bump to Go 1.23.7 and x/net that wants/suggests it. But, it is a bit fishy though that manual go tidy does not add it, so maybe there is something funky going on with the bot. Generally, the mechnism is:
In these cases, it will add the toolchain directive, with Go version that is present in the environment doing the bump. Dependabot is clearly having the latest 1.24.1 as that is being added. |
|
Thx for the explanation! Wondering if we can configure dependabot to use another Go version and if the issue would then go away (It was sort of fine for a while, but if we now have to fixup every single dependabot PR this will get very annoying quickly) |
I assume dependabot has to run the latest version as the modules can actually use the latest language features and it must be able to handle them.
I agree, let's hope it is just temporary. Seems there is issue about it: dependabot/dependabot-core#11825 |
fabriziopandini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bumps the all-go-mod-patch-and-minor group with 5 updates in the / directory:
1.19.01.20.00.32.20.32.30.32.20.32.30.32.20.32.30.36.00.37.0Bumps the all-go-mod-patch-and-minor group with 6 updates in the /hack/tools directory:
1.19.01.20.00.32.20.32.30.32.20.32.30.32.20.32.31.50.01.51.00.224.00.226.0Bumps the all-go-mod-patch-and-minor group with 5 updates in the /test directory:
1.19.01.20.00.32.20.32.30.32.20.32.30.32.20.32.30.36.00.37.0Updates
github.com/spf13/viperfrom 1.19.0 to 1.20.0Release notes
Sourced from github.com/spf13/viper's releases.
... (truncated)
Commits
c038295docs: add update instructions for 1.209c07e0fbuild: disable unused linters48112d6ci: add Go 1.24 to the test matrix66e3e28build(deps): bump github.com/spf13/pflag from 1.0.5 to 1.0.617b96acNew Logo8b223a4build(deps): bump github.com/spf13/cast from 1.7.0 to 1.7.191fd363chore: update aferoe75c48fFix issues reported by testifylinta5ea569build(deps): bump github/codeql-action from 3.27.7 to 3.27.954f2089build(deps): bump golang.org/x/crypto from 0.27.0 to 0.31.0 in /remoteUpdates
google.golang.org/grpcfrom 1.65.1 to 1.67.3Release notes
Sourced from google.golang.org/grpc's releases.
... (truncated)
Commits
117cd63Update version to 1.67.3 (#7939)c4e695ev1.67: remove opentelemetry module and pull into main module (#7935)0f8fa3eChange version to 1.67.3-dev (#7896)b0e0bf0Change version to 1.67.2 (#7893)44c2affcredentials/alts: avoid SRV and TXT lookups for handshaker service (#7861) (#...a1c3cfbChange version to 1.67.2-dev (#7683)3f95b38Update version to 1.67.1 (#7682)4f6c5f2xds/server: Fix xDS Server leak (#7664) (#7681)935f8cbtransport: Fix reporting of bytes read while reading headers (#7660) (#7667)02bbb65Change version to 1.67.1-dev (#7605)Updates
k8s.io/apifrom 0.32.2 to 0.32.3Commits
22c1e39Update dependencies to v0.32.3 tag40f4980Merge pull request #129690pohly/automated-cherry-pick-of-#129661a5598f8DRA CEL: add missing size estimatorUpdates
k8s.io/apiextensions-apiserverfrom 0.32.2 to 0.32.3Commits
0350e46Update dependencies to v0.32.3 tagUpdates
k8s.io/apimachineryfrom 0.32.2 to 0.32.3Commits
Updates
k8s.io/apiserverfrom 0.32.2 to 0.32.3Commits
d5dc369Update dependencies to v0.32.3 tag4f51d06Merge pull request #130136 from AwesomePatrol/automated-cherry-pick-of-#13011...a85a34bMerge pull request #130253 from fuweid/1.32-backport-130126fc2ddd4proxy: should add PingPeriod for websocket translatorf279152Limit ResourceQuota LIST requests to times when informer is not syncedUpdates
k8s.io/client-gofrom 0.32.2 to 0.32.3Commits
c106b23Update dependencies to v0.32.3 tagUpdates
k8s.io/cluster-bootstrapfrom 0.32.2 to 0.32.3Commits
a03a3adUpdate dependencies to v0.32.3 tagUpdates
k8s.io/component-basefrom 0.32.2 to 0.32.3Commits
c9cca2fUpdate dependencies to v0.32.3 tagUpdates
golang.org/x/netfrom 0.36.0 to 0.37.0Commits
99b3ae0go.mod: update golang.org/x dependenciesUpdates
github.com/spf13/viperfrom 1.19.0 to 1.20.0Release notes
Sourced from github.com/spf13/viper's releases.
... (truncated)
Commits
c038295docs: add update instructions for 1.209c07e0fbuild: disable unused linters48112d6ci: add Go 1.24 to the test matrix66e3e28build(deps): bump github.com/spf13/pflag from 1.0.5 to 1.0.617b96acNew Logo8b223a4build(deps): bump github.com/spf13/cast from 1.7.0 to 1.7.191fd363chore: update aferoe75c48fFix issues reported by testifylinta5ea569build(deps): bump github/codeql-action from 3.27.7 to 3.27.954f2089build(deps): bump golang.org/x/crypto from 0.27.0 to 0.31.0 in /remoteUpdates
k8s.io/apifrom 0.32.2 to 0.32.3Commits
22c1e39Update dependencies to v0.32.3 tag40f4980Merge pull request #129690pohly/automated-cherry-pick-of-#129661a5598f8DRA CEL: add missing size estimatorUpdates
k8s.io/apiextensions-apiserverfrom 0.32.2 to 0.32.3Commits
0350e46Update dependencies to v0.32.3 tagUpdates
k8s.io/apimachineryfrom 0.32.2 to 0.32.3Commits
Updates
k8s.io/apiserverfrom 0.32.2 to 0.32.3Commits
d5dc369Update dependencies to v0.32.3 tag4f51d06Merge pull request #130136 from AwesomePatrol/automated-cherry-pick-of-#13011...a85a34bMerge pull request #130253 from fuweid/1.32-backport-130126fc2ddd4proxy: should add PingPeriod for websocket translatorf279152Limit ResourceQuota LIST requests to times when informer is not syncedUpdates
k8s.io/client-gofrom 0.32.2 to 0.32.3Commits
c106b23Update dependencies to v0.32.3 tagUpdates
k8s.io/cluster-bootstrapfrom 0.32.2 to 0.32.3Commits
a03a3adUpdate dependencies to v0.32.3 tagUpdates
k8s.io/component-basefrom 0.32.2 to 0.32.3Commits
c9cca2fUpdate dependencies to v0.32.3 tagUpdates
cloud.google.com/go/storagefrom 1.50.0 to 1.51.0Commits
2fb3eb7chore(main): release spanner 1.51.0 (#8710)ef872d8chore: add support for running module dir tests in continuous (#8735)2105434fix(bigtable): return cluster error for Update when populated (#8657)deeb583fix(profiler): migrate to protobuf-go v2 (#8730)2077158test(bigtable): Run conformance tests for bigtable (#8658)3df0287feat(storage): support MatchGlob for gRPC (#8670)d21429echore(storage): add invocation ID to gRPC calls (#8698)9aa4082chore(github): remove unused OwlBot configuration (#8733)6cc6d70chore: update sa for loading secrets (#8729)fe554b5chore: source secrets for tests (#8728)Updates
google.golang.org/apifrom 0.224.0 to 0.226.0Release notes
Sourced from google.golang.org/api's releases.
Changelog
Sourced from google.golang.org/api's changelog.
Commits
be5fb5dchore(main): release 0.226.0 (#3060)7789423chore(deps): bump golang.org/x/net to 0.37.0 (#3063)bcbcd33chore(deps): bump golang.org/x/net in /internal/kokoro/discogen (#3061)36a4396feat(all): auto-regenerate discovery clients (#3059)d6dfa1dchore(main): release 0.225.0 (#3053)fe0dd61fix(option): update WithEndpoint docs (#3032)1b9abf7feat(all): auto-regenerate discovery clients (#3058)af5a977chore(all): update all (#3056)7a464eafeat(all): auto-regenerate discovery clients (#3057)01546c1feat(all): auto-regenerate discovery clients (#3055)Updates
google.golang.org/grpcfrom 1.70.0 to 1.71.0Release notes
Sourced from google.golang.org/grpc's releases.
... (truncated)
Commits
117cd63Update version to 1.67.3 (#7939)c4e695ev1.67: remove opentelemetry module and pull into main module (#7935)0f8fa3eChange version to 1.67.3-dev (#7896)b0e0bf0Change version to 1.67.2 (#7893)44c2affcredentials/alts: avoid SRV and TXT lookups for handshaker service (#7861) (#...a1c3cfbChange version to 1.67.2-dev (#7683)3f95b38Update version to 1.67.1 (#7682)4f6c5f2xds/server: Fix xDS Server leak (#7664) (#7681)935f8cbtransport: Fix reporting of bytes read while reading headers (#7660) (#7667)02bbb65Change version to 1.67.1-dev (#7605)Updates
github.com/spf13/viperfrom 1.19.0 to 1.20.0Release notes
Sourced from github.com/spf13/viper's releases.
... (truncated)
Commits
c038295docs: add update instructions for 1.209c07e0fbuild: disable unused linters48112d6ci: add Go 1.24 to the test matrix66e3e28build(deps): bum...Description has been truncated