🌱 Remove deprecated ClusterResourceSet feature gate #12950
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing Please see the labels list for possible areas. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
aman4433
force-pushed
the
remove-clusterresourceset-featuregate
branch
from
6477e1e to
3e358dc
Compare
k8s-ci-robot
added
size/M
aman4433
force-pushed
the
remove-clusterresourceset-featuregate
branch
from
3e358dc to
fa597bf
Compare
|
/test pull-cluster-api-test-main |
|
/test pull-cluster-api-e2e-blocking-main |
aman4433
force-pushed
the
remove-clusterresourceset-featuregate
branch
from
fa597bf to
7bc675b
Compare
|
@aman4433: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| "can be set only if the ClusterResourceSet feature flag is enabled", | ||
| ) | ||
| } | ||
| // NOTE: The entire "if !feature.Gates.Enabled(feature.ClusterResourceSet)" block has been removed. |
There was a problem hiding this comment.
| // NOTE: The entire "if !feature.Gates.Enabled(feature.ClusterResourceSet)" block has been removed. |
No need to document that we dropped it
| "can be set only if the ClusterResourceSet feature flag is enabled", | ||
| ) | ||
| } | ||
| // NOTE: The "if !feature.Gates.Enabled(feature.ClusterResourceSet)" block has been removed. |
There was a problem hiding this comment.
| // NOTE: The "if !feature.Gates.Enabled(feature.ClusterResourceSet)" block has been removed. |
| // | ||
| // alpha: v0.3 | ||
| // beta: v1.7 | ||
| MachinePool featuregate.Feature = "MachinePool" |
There was a problem hiding this comment.
Let's also:
- Remove
,ClusterResourceSet=${EXP_CLUSTER_RESOURCE_SET:=true}from config/manager/manager.yaml - Remove l.6-l.11 in docs/book/src/tasks/cluster-resource-set.md
3 participants
What this PR does / why we need it:
This PR removes the deprecated ClusterResourceSet feature gate, which has been GA since v1.11.
Ref: Remove previously deprecated code
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Task of #12771
Fixes #11114