✨ Add e2e test template to check whether the upgrade plan works correctly #12955
Conversation
Signed-off-by: sivchari <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-cluster-api-e2e-latestk8s-main |
|
/retest |
| upgrade: | ||
| external: | ||
| generateUpgradePlanExtension: generate-upgrade-plan.${EXTENSION_CONFIG_NAME:-k8s-upgrade-with-runtimesdk} |
There was a problem hiding this comment.
@sivchari if I got this right, this is the only difference between the test introduced by this PR and the existing runtime SDK test.
If this is correct, considering that this test takes long, I would be ok if we move this change to clusterclass-quick-start-runtimesdk and have only one test (I'm also considering that we have good test coverage for the different ways of computing upgrade plan, and that the runtime extension internally uses the same func we use when only kubernetes versions are set).
wdyt?
@sbueringer opinions?
There was a problem hiding this comment.
Sounds good. Let's just add this to the clusterclass-quick-start-runtimesdk ClusterClass and revert the rest of the changes on this PR
@sivchari Sorry we didn't think about this when writing up the tasks
4 participants
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #12720