Skip to content

Conversation

@fabriziopandini
Copy link
Member

What this PR does / why we need it:
... and make sure we are checking in place updating consistently (also checking this in a few additional place to make replica counters and conditions more consistent)

/area machine
/area machinedeployment
/area machineset

@k8s-ci-robot k8s-ci-robot added area/machine Issues or PRs related to machine lifecycle management area/machinedeployment Issues or PRs related to machinedeployments area/machineset Issues or PRs related to machinesets cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 5, 2025
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 5, 2025
@fabriziopandini fabriziopandini force-pushed the move-up-to-date-condition-to-ms-for-workers branch from cddc59b to c20493a Compare November 6, 2025 11:10
@fabriziopandini fabriziopandini force-pushed the move-up-to-date-condition-to-ms-for-workers branch from c20493a to bab3437 Compare November 6, 2025 15:14
@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 6, 2025
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b4a4fc11c69b76544c6891c4253b5f6fead6eacb

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 043957b into kubernetes-sigs:main Nov 6, 2025
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Nov 6, 2025
@sbueringer sbueringer changed the title 🌱 Move up to date condition to ms for workers 🌱 Adjust UpToDate condition to consider Updating, move UpToDate condition to Machine ctrl for workers Nov 7, 2025
@fabriziopandini fabriziopandini deleted the move-up-to-date-condition-to-ms-for-workers branch November 11, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/machine Issues or PRs related to machine lifecycle management area/machinedeployment Issues or PRs related to machinedeployments area/machineset Issues or PRs related to machinesets cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants