-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 Adjust UpToDate condition to consider Updating, move UpToDate condition to Machine ctrl for workers #12959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
k8s-ci-robot
merged 3 commits into
kubernetes-sigs:main
from
fabriziopandini:move-up-to-date-condition-to-ms-for-workers
Nov 6, 2025
Merged
🌱 Adjust UpToDate condition to consider Updating, move UpToDate condition to Machine ctrl for workers #12959
k8s-ci-robot
merged 3 commits into
kubernetes-sigs:main
from
fabriziopandini:move-up-to-date-condition-to-ms-for-workers
Nov 6, 2025
+814
−474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cddc59b to
c20493a
Compare
sbueringer
reviewed
Nov 6, 2025
c20493a to
bab3437
Compare
Member
|
/lgtm |
Contributor
|
LGTM label has been added. Git tree hash: b4a4fc11c69b76544c6891c4253b5f6fead6eacb
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
79 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/machine
Issues or PRs related to machine lifecycle management
area/machinedeployment
Issues or PRs related to machinedeployments
area/machineset
Issues or PRs related to machinesets
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
tide/merge-method-squash
Denotes a PR that should be squashed by tide when it merges.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
... and make sure we are checking in place updating consistently (also checking this in a few additional place to make replica counters and conditions more consistent)
/area machine
/area machinedeployment
/area machineset