-
Notifications
You must be signed in to change notification settings - Fork 1.4k
⚠️ Improve chained upgrade observability #12973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
⚠️ Improve chained upgrade observability #12973
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5b7cf3e to
1938697
Compare
1938697 to
c1db929
Compare
|
/test |
|
@fabriziopandini: The The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cluster-api-e2e-main-gke |
1 similar comment
|
/test pull-cluster-api-e2e-main-gke |
c1db929 to
d5b0a2d
Compare
|
/test pull-cluster-api-e2e-main-gke |
d5b0a2d to
67cc286
Compare
|
/test pull-cluster-api-e2e-main-gke |
|
@fabriziopandini: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Make sure all lifecycle hooks are logging in a consist way, and also makes the Topology reconcile condition to surface details about progress on the chained process.
Given the complexity of this process following reasons have been deprecated
e.g. ControlPlaneUpgradePending will remain true for most of the chained upgrades, thus making harder to follow progress.
Notably, this reason is used till the entire upgrade is completed, including lifecycle hooks.
As a replacement the following reason ha been introduced, and with a corresponding multiline message providing details on the upgrade process.
Please also note that theLifecycleHookBlocking reason is not used anymore, because hooks are integral part of the cluster upgrade workflow (or of the cluster provisioning/deletion workflows).
/area runtime-sdk