Skip to content

Conversation

@fabriziopandini
Copy link
Member

What this PR does / why we need it:
Make sure all lifecycle hooks are logging in a consist way, and also makes the Topology reconcile condition to surface details about progress on the chained process.

Given the complexity of this process following reasons have been deprecated

	ClusterTopologyReconciledControlPlaneUpgradePendingReason = "ControlPlaneUpgradePending"
	ClusterTopologyReconciledMachineDeploymentsCreatePendingReason = "MachineDeploymentsCreatePending"
	ClusterTopologyReconciledMachineDeploymentsUpgradePendingReason = "MachineDeploymentsUpgradePending"
	ClusterTopologyReconciledMachinePoolsUpgradePendingReason = "MachinePoolsUpgradePending"
	ClusterTopologyReconciledMachinePoolsCreatePendingReason = "MachinePoolsCreatePending"
	ClusterTopologyReconciledMachinePoolsUpgradeDeferredReason = "MachinePoolsUpgradeDeferred"
	ClusterTopologyReconciledHookBlockingReason = "LifecycleHookBlocking"

e.g. ControlPlaneUpgradePending will remain true for most of the chained upgrades, thus making harder to follow progress.
Notably, this reason is used till the entire upgrade is completed, including lifecycle hooks.

As a replacement the following reason ha been introduced, and with a corresponding multiline message providing details on the upgrade process.

	// ClusterTopologyReconciledClusterUpgradingReason documents reconciliation of a Cluster topology
	// not yet completed because a cluster upgrade is still in progress.
	ClusterTopologyReconciledClusterUpgradingReason = "ClusterUpgrading"

Please also note that theLifecycleHookBlocking reason is not used anymore, because hooks are integral part of the cluster upgrade workflow (or of the cluster provisioning/deletion workflows).

/area runtime-sdk

@k8s-ci-robot k8s-ci-robot added area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 7, 2025
@fabriziopandini fabriziopandini force-pushed the improve-chained-upgrade-observability branch from 5b7cf3e to 1938697 Compare November 7, 2025 17:49
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2025
@fabriziopandini fabriziopandini force-pushed the improve-chained-upgrade-observability branch from 1938697 to c1db929 Compare November 7, 2025 18:16
@fabriziopandini
Copy link
Member Author

/test

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test pull-cluster-api-build-main
/test pull-cluster-api-e2e-blocking-main
/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-latestk8s-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-main-gke
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-34-1-35-main
/test pull-cluster-api-test-main
/test pull-cluster-api-test-mink8s-main
/test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-apidiff-main
pull-cluster-api-build-main
pull-cluster-api-e2e-blocking-main
pull-cluster-api-test-main
pull-cluster-api-verify-main

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-main-gke

1 similar comment
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-main-gke

@fabriziopandini fabriziopandini force-pushed the improve-chained-upgrade-observability branch from c1db929 to d5b0a2d Compare November 9, 2025 14:03
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-main-gke

@fabriziopandini fabriziopandini force-pushed the improve-chained-upgrade-observability branch from d5b0a2d to 67cc286 Compare November 9, 2025 14:11
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-main-gke

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 9, 2025

@fabriziopandini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 67cc286 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants