Skip to content

🌱 use modernize linter #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 use modernize linter #1300

wants to merge 1 commit into from
+133 −138

Conversation

@HaraldNordgren
Copy link
Contributor

@HaraldNordgren HaraldNordgren commented Oct 30, 2025

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 30, 2025
@HaraldNordgren HaraldNordgren changed the title modernize for loops modernize counting loops Oct 30, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 30, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 30, 2025

Hi @HaraldNordgren. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 30, 2025
@HaraldNordgren HaraldNordgren changed the title modernize counting loops 🌱 modernize counting loops Oct 30, 2025
@HaraldNordgren HaraldNordgren changed the title 🌱 modernize counting loops 🌱 modernize loops Oct 30, 2025
@HaraldNordgren HaraldNordgren marked this pull request as ready for review October 30, 2025 16:47
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2025
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 30, 2025

/ok-to-test

Is there a linter we can use to prevent people using this old style?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 30, 2025
@HaraldNordgren
Copy link
Contributor Author

HaraldNordgren commented Nov 1, 2025

/retest

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2025
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 1, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 1, 2025
@HaraldNordgren HaraldNordgren reopened this Nov 1, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: HaraldNordgren
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: HaraldNordgren
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2025
@HaraldNordgren HaraldNordgren changed the title 🌱 modernize loops 🌱 use modernize linter Nov 1, 2025
@HaraldNordgren HaraldNordgren force-pushed the main branch 3 times, most recently from 719c48e to e282e18 Compare November 1, 2025 14:46
HaraldNordgren
HaraldNordgren commented Nov 1, 2025
View reviewed changes
pkg/applyconfiguration/applyconfiguration_integration_test.go
content = []byte(strings.ReplaceAll(string(content), "testdata/cronjob/api/v1/applyconfiguration", filepath.Join("testdata/cronjob/api/v1", outputPackage)))

// Make sure the interface{} is replaced with any.
content = []byte(strings.ReplaceAll(string(content), "any", "interface{}"))
Copy link
Contributor Author

@HaraldNordgren HaraldNordgren Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this is necessary, it's causes by my changing the signature of ForKind. But it's not clear to me why I can't get Golang to just output "any" on the generated code.

@HaraldNordgren
Copy link
Contributor Author

HaraldNordgren commented Nov 9, 2025

Hi @JoelSpeed, there is the modernize linter which I added now, it required me to change more than I expected.

Do you think it's a good change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alvaroaleman alvaroaleman Awaiting requested review from alvaroaleman

@vincepri vincepri Awaiting requested review from vincepri

@chrischdi chrischdi Awaiting requested review from chrischdi

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HaraldNordgren @k8s-ci-robot @JoelSpeed