-
Notifications
You must be signed in to change notification settings - Fork 82
Ensure compatibility with default Kubernetes v1.34 clusters #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure compatibility with default Kubernetes v1.34 clusters #123
Conversation
|
|
|
Welcome @enoodle! |
|
For context, some of the versions were kept at v1beta1 in #116 to maintain compatibility back to Kubernetes v1.32. There are a couple of changes though that will make things a bit smoother for v1.34+ users:
@enoodle Would you be willing to reformulate this PR to address those points? |
|
Thanks @nojnhuh , I'll look into updating the PR with these changes, hopefully next week. |
151bbe1 to
91822ab
Compare
|
@nojnhuh I updated the PR with the requested changes from |
|
Thanks @enoodle! I promise I haven't lost track of this, it's still on my list to review. |
nojnhuh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested that this doesn't obviously break upgrading from a previous version of the driver and that things work with a 1.34 kind cluster without any config overrides aside from adding a worker node.
Just left one minor cleanup comment.
|
@bart0sh If you have perms to invoke CI for this PR that would be good to run. Thanks! |
|
@enoodle This looks good, thanks! Could you please squash your changes into one commit? I think this more accurately reflects the new scope of the PR: /retitle Ensure compatibility with default Kubernetes v1.34 clusters @bart0sh @pohly @klueska I think this PR is good to go, but would like to get a positive signal from CI to make sure I'm not missing anything. I don't have permission to kick off the jobs, could one of you please do that? |
8c86e3b to
30b6216
Compare
Bump the API version from v1beta1 to v1 in all relevant files, including Go imports, Helm charts, and test cases. This ensures compatibility with the latest Kubernetes resource APIs.
30b6216 to
f5336c9
Compare
nojnhuh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks @enoodle!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enoodle, nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bump the API version from v1beta1 to v1 in all relevant files, including Go imports, Helm charts, and test cases. This ensures compatibility with the latest Kubernetes resource APIs.