Skip to content

Conversation

@enoodle
Copy link
Contributor

@enoodle enoodle commented Sep 26, 2025

Bump the API version from v1beta1 to v1 in all relevant files, including Go imports, Helm charts, and test cases. This ensures compatibility with the latest Kubernetes resource APIs.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 26, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: enoodle / name: Erez Freiberger (f5336c9)

@k8s-ci-robot
Copy link
Contributor

Welcome @enoodle!

It looks like this is your first PR to kubernetes-sigs/dra-example-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/dra-example-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 26, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 26, 2025
@nojnhuh
Copy link
Contributor

nojnhuh commented Sep 27, 2025

For context, some of the versions were kept at v1beta1 in #116 to maintain compatibility back to Kubernetes v1.32. There are a couple of changes though that will make things a bit smoother for v1.34+ users:

@enoodle Would you be willing to reformulate this PR to address those points?

@enoodle
Copy link
Contributor Author

enoodle commented Sep 27, 2025

Thanks @nojnhuh , I'll look into updating the PR with these changes, hopefully next week.

@pohly pohly moved this from 🆕 New to 👀 In review in Dynamic Resource Allocation Sep 29, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 29, 2025
@enoodle enoodle force-pushed the erez/use-k8s-1-34-v1-api branch from 151bbe1 to 91822ab Compare September 29, 2025 11:55
@enoodle
Copy link
Contributor Author

enoodle commented Sep 29, 2025

@nojnhuh I updated the PR with the requested changes from github.com/NVIDIA/k8s-dra-drive-gpu. I also added v1beta2 because it seemed weird to leave it out.

@nojnhuh
Copy link
Contributor

nojnhuh commented Oct 7, 2025

Thanks @enoodle! I promise I haven't lost track of this, it's still on my list to review.

Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested that this doesn't obviously break upgrading from a previous version of the driver and that things work with a 1.34 kind cluster without any config overrides aside from adding a worker node.

Just left one minor cleanup comment.

@nojnhuh
Copy link
Contributor

nojnhuh commented Oct 9, 2025

@bart0sh If you have perms to invoke CI for this PR that would be good to run. Thanks!

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 10, 2025
@nojnhuh
Copy link
Contributor

nojnhuh commented Oct 27, 2025

@enoodle This looks good, thanks! Could you please squash your changes into one commit?

I think this more accurately reflects the new scope of the PR:

/retitle Ensure compatibility with default Kubernetes v1.34 clusters

@bart0sh @pohly @klueska I think this PR is good to go, but would like to get a positive signal from CI to make sure I'm not missing anything. I don't have permission to kick off the jobs, could one of you please do that?

@k8s-ci-robot k8s-ci-robot changed the title Update DRA API version to v1 Ensure compatibility with default Kubernetes v1.34 clusters Oct 27, 2025
@enoodle enoodle force-pushed the erez/use-k8s-1-34-v1-api branch from 8c86e3b to 30b6216 Compare October 28, 2025 08:51
Bump the API version from v1beta1 to v1 in all relevant files, including Go imports, Helm charts, and test cases. This ensures compatibility with the latest Kubernetes resource APIs.
@enoodle enoodle force-pushed the erez/use-k8s-1-34-v1-api branch from 30b6216 to f5336c9 Compare October 28, 2025 09:27
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @enoodle!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enoodle, nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1c55f17 into kubernetes-sigs:main Oct 28, 2025
6 checks passed
@nojnhuh nojnhuh moved this from 👀 In review to ✅ Done in Dynamic Resource Allocation Oct 28, 2025
@enoodle enoodle deleted the erez/use-k8s-1-34-v1-api branch October 28, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants