refactor log collection #3986
Merged
refactor log collection #3986
+82
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/provider/docker
k8s-ci-robot
added
the
size/L
stmcginnis
reviewed
Aug 13, 2025
| } | ||
|
|
||
| fns = append(fns, func() error { | ||
| return internallogs.DumpDir(p.logger, node, "/var/log", path) |
Contributor
There was a problem hiding this comment.
Isn't this being done for all providers at the top level?
Member
Author
There was a problem hiding this comment.
Looks like this got left behind in the docker provider but not the others, will follow up 😳
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulled out from https://github.com/kubernetes-sigs/kind/pull/3980/commits
I'm not sure if we should actually dump the metrics on each node or not, and currently I'm pursuing a KEP related to how we'd test metrics which is going to take another route ...
So in the meantime, splitting out the cleanup from the behavior changes.