-
Notifications
You must be signed in to change notification settings - Fork 257
kro cli: Create and dry run command for RGD #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
kro cli: Create and dry run command for RGD #575
Conversation
|
Kubectl has a diff. Would this add more functionality than what is available in kubectl ? Also we would need to rebase this to conform to the new cli directory structure. We see value in showing diff in the rendered objects for an RGD instances. Thats not what this PR seems to be doing. |
|
Hi @barney-s, thanks for the feedback! |
|
@markoskandylis - Would you be inclined to implement the terraform plan like capability instead of this PR ? You can do it in a new PR or replace this PR code with the plan like functionality. |
barney-s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would like to have the plan equivalent. Essentially diff of generated resources. Diffing instance or RGD is not desirable atm. Simple git diff or kubectl diff would work for those cases.
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
|
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Add Create Command with Dry-Run Functionality to KRO CLI
Description
Adds the
createcommand to the KRO CLI with dry-run functionality. This enhancement allows users to preview RGD (Resource Graph Definition) changes before applying them to the cluster.Features
create rgdcommand--dry-runflag optionImplementation Details
kro create rgd [FILE]kro create rgd [FILE] --dry-runDemo
smaller.mov