chore: small refactor of dynamic controller funcs #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakob Möller <[email protected]>
- Replace `interface{}` with `any` for cleaner type definitions.
- Enhance error propagation in `handlerForChildGVR`.
- Move parent GVK resolution to the handler creation phase, reducing repetitive logic.
Signed-off-by: Jakob Möller <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
jakobmoellerdev
changed the title
k8s-ci-robot
added
lgtm
Contributor
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
tjamet
approved these changes
Nov 7, 2025
tjamet
left a comment
tjamet
left a comment
There was a problem hiding this comment.
+1 on favouring more explicit any rather than interface{}
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, jakobmoellerdev, tjamet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds small refactors around dynamic controller raised within #611 (review)