-
Notifications
You must be signed in to change notification settings - Fork 6.8k
change kubectl_node_schedulable var #12661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change kubectl_node_schedulable var #12661
Conversation
|
Hi @rptaylor. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/retest |
|
@rptaylor, please rebase this PR |
57911cc to
a10ed2d
Compare
|
@tico88612 Okay I rebased it, can you please approve and merge before it gets out of date again? |
|
Looks like the CI/CD is broken. |
tico88612
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rptaylor, tico88612 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
If you have these nodes:
then the results of this query are:
In other words
kubectl_node_schedulableis the opposite of what it says - it is true if the node is un schedulable.Which issue(s) this PR fixes:
Make the name of the variable match the logic of the variable to improve readability and avoid the risk of confusion and errors.
Special notes for your reviewer:
Does this PR introduce a user-facing change?: