Skip to content

Conversation

@rptaylor
Copy link
Contributor

@rptaylor rptaylor commented Oct 30, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
If you have these nodes:

cluster-k8s-node-x39      Ready                      <none>          279d     v1.29.10
cluster-k8s-node-x40      Ready,SchedulingDisabled   <none>          279d     v1.29.10

then the results of this query are:

$ kubectl get node cluster-k8s-node-x39 -o jsonpath='{ .spec.unschedulable }'
$ kubectl get node cluster-k8s-node-x40 -o jsonpath='{ .spec.unschedulable }'
true

In other words kubectl_node_schedulable is the opposite of what it says - it is true if the node is un schedulable.

Which issue(s) this PR fixes:

Make the name of the variable match the logic of the variable to improve readability and avoid the risk of confusion and errors.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 30, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 30, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @rptaylor. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yankay
Copy link
Member

yankay commented Nov 6, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2025
@tico88612
Copy link
Member

/retest

@tico88612
Copy link
Member

@rptaylor, please rebase this PR

@rptaylor rptaylor force-pushed the 20251030-node-schedulable-var branch from 57911cc to a10ed2d Compare November 14, 2025 16:49
@rptaylor
Copy link
Contributor Author

@tico88612 Okay I rebased it, can you please approve and merge before it gets out of date again?

@rptaylor
Copy link
Contributor Author

Looks like the CI/CD is broken.

Copy link
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rptaylor, tico88612

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit dab0947 into kubernetes-sigs:master Nov 15, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants