Skip to content

Conversation

@vladikkuzn
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #5773

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 17, 2025
@k8s-ci-robot k8s-ci-robot requested a review from mimowo October 17, 2025 09:02
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vladikkuzn
Once this PR has been reviewed and has the lgtm label, please assign gabesaba for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from tenzen-y October 17, 2025 09:02
@netlify
Copy link

netlify bot commented Oct 17, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit ef37822
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/68f745f111dd3b0008ec168a

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 17, 2025
@vladikkuzn
Copy link
Contributor Author

/assign

@mimowo
Copy link
Contributor

mimowo commented Oct 17, 2025

cc @mbobrovskyi @mszadkow for early feedback

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove this file, since we probably won't self-host

@vladikkuzn
Copy link
Contributor Author

/cc @mbobrovskyi @mszadkow

@mbobrovskyi
Copy link
Contributor

@vladikkuzn did you test it in local fork?

uses: renovatebot/[email protected]
with:
# Use GitHub-provided token for this repository
token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need write permission for this token?

@mimowo Can we add it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Token should have all necessary permissions already, IIUC GH adds them automatically

Copy link
Contributor

@mbobrovskyi mbobrovskyi Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Token should have all necessary permissions already

Are you sure? Did you test it?

IIUC GH adds them automatically

No, the GITHUB_TOKEN is a manually created secret.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I think you right, we already have this:

    permissions:
      contents: write
      pull-requests: write

Copy link
Contributor

@mbobrovskyi mbobrovskyi Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But still, could you please test it in your own fork to make sure?

@vladikkuzn vladikkuzn force-pushed the kueueviz-frontend-manage-via-renovate branch 4 times, most recently from 4e31471 to 7d5f086 Compare October 17, 2025 14:00
@vladikkuzn
Copy link
Contributor Author

@vladikkuzn did you test it in local fork?

@mbobrovskyi What do you mean?

@mbobrovskyi
Copy link
Contributor

mbobrovskyi commented Oct 17, 2025

@mbobrovskyi What do you mean?

I mean your own fork. How did you test it?

@mimowo
Copy link
Contributor

mimowo commented Oct 20, 2025

+1 to testing on a local fork first

@vladikkuzn vladikkuzn force-pushed the kueueviz-frontend-manage-via-renovate branch from 7d5f086 to ef37822 Compare October 21, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

do-not-merge/invalid-commit-message appears when creating a bump PR for dependencies with an @ prefix

4 participants