-
Notifications
You must be signed in to change notification settings - Fork 451
kueueviz frontend manage via renovate #7310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
kueueviz frontend manage via renovate #7310
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vladikkuzn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
/assign |
|
cc @mbobrovskyi @mszadkow for early feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove this file, since we probably won't self-host
|
@vladikkuzn did you test it in local fork? |
| uses: renovatebot/[email protected] | ||
| with: | ||
| # Use GitHub-provided token for this repository | ||
| token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need write permission for this token?
@mimowo Can we add it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Token should have all necessary permissions already, IIUC GH adds them automatically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Token should have all necessary permissions already
Are you sure? Did you test it?
IIUC GH adds them automatically
No, the GITHUB_TOKEN is a manually created secret.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think you right, we already have this:
permissions:
contents: write
pull-requests: write
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But still, could you please test it in your own fork to make sure?
4e31471 to
7d5f086
Compare
@mbobrovskyi What do you mean? |
I mean your own fork. How did you test it? |
|
+1 to testing on a local fork first |
7d5f086 to
ef37822
Compare
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #5773
Special notes for your reviewer:
Does this PR introduce a user-facing change?