Document sourceValue for replacements.
#5974
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: VannTen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
stormqueen1990
left a comment
stormqueen1990
left a comment
There was a problem hiding this comment.
Hi there, @VannTen! Thanks for your contribution!
I just found a minor typo, other than that LGTM.
/lgtm
| | -----------: | :----: | ----------- | ---- | | ||
| | `source`| ✔️ | The source of the value | | ||
| | `source`| | The source of the value | | ||
| | `sourceValue`| | The litteral value to use as source | |
There was a problem hiding this comment.
Very minor: there's an extra "t" in literal here.
| | `sourceValue`| | The litteral value to use as source | | |
| | `sourceValue`| | The literal value to use as source | |
There was a problem hiding this comment.
Oh right, not sure how it got there 😆
k8s-ci-robot
added
the
lgtm
VannTen
force-pushed
the
docs/sourceValue
branch
from
0bff698 to
479fb24
Compare
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
| | -----------: | :----: | ----------- | ---- | | ||
| | `source`| ✔️ | The source of the value | | ||
| | `source`| | The source of the value | | ||
| | `sourceValue`| | The literal value to use as source | |
There was a problem hiding this comment.
| | `sourceValue`| | The literal value to use as source | | |
| | `sourceValue`| | The literal value to use as the source value | |
| The source field is a selector that determines the source of the value by finding a | ||
| match to the specified GVKNN. All the subfields of `source` are optional, | ||
| but the source selection must resolve to a single resource. | ||
| The source can also be specified directly as a string using `sourceValue`. |
There was a problem hiding this comment.
Alternately, instead of selecting and extracting a value from a referenced resource, you can specify a literal string value for the source directly in the sourceValue field.
There was a problem hiding this comment.
instead of selecting and extracting a value from a referenced resource
IMO that fragment only repeats the above and does not really help, but I do like the rest of your formulation better.
Co-authored-by: Steven E. Harris <[email protected]>
VannTen
force-pushed
the
docs/sourceValue
branch
from
479fb24 to
2e3df96
Compare
4 participants
The field was introduced in #5630 but not documented.