-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Updated azure static sku list #8507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The committers listed above are authorized under a signed CLA. |
|
Welcome @yanjar! |
|
Hi @yanjar. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
@Bryce-Soghigian @rakechill @comtalyst @tallaxes I ran the |
|
/cherry-pick cluster-autoscaler-release-1.30 |
|
@jackfrancis: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi! Just wanted to express support for this PR - the updated Azure SKU list would be very helpful for our workloads. May I kindly ask if there are any outstanding requirements or blockers preventing further review or approval? If there’s anything I can do to assist or help move this forward, I’d be happy to contribute. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rakechill, tallaxes, yanjar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@jackfrancis: new pull request created: #8808 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jackfrancis: new pull request created: #8809 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jackfrancis: new pull request created: #8810 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jackfrancis: new pull request created: #8811 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick cluster-autoscaler-release-1.34 |
|
@jackfrancis: new pull request created: #8812 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@rakechill since |
Ah, it's different for our managed users. Sorry about that. We can also go ahead and default this to true for self-hosted. I'll make a PR today. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This regenerates the azure static sku list since there are newer SKUs that are not listed such as the
StandardDsv6Family.Generated by running
./autoscaler/cluster-autoscaler/cloudprovider/azure/azure_instance_types/gen.goSpecial notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: