Skip to content

Conversation

@yanjar
Copy link
Contributor

@yanjar yanjar commented Sep 8, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

This regenerates the azure static sku list since there are newer SKUs that are not listed such as the StandardDsv6Family.
Generated by running ./autoscaler/cluster-autoscaler/cloudprovider/azure/azure_instance_types/gen.go

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Regenerate Azure static SKU list

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Sep 8, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 8, 2025

CLA Signed

  • ✅login: yanjar / name: Jared Yanna / (66046af)

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @yanjar!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 8, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @yanjar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 8, 2025
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/needs-area cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 8, 2025
@jackfrancis
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2025
@jackfrancis
Copy link
Contributor

@Bryce-Soghigian @rakechill @comtalyst @tallaxes I ran the gen.go file and got the same output. Do we want to cherry-pick these changes back into previous branches?

@jackfrancis
Copy link
Contributor

/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.32
/cherry-pick cluster-autoscaler-release-1.33

@k8s-infra-cherrypick-robot

@jackfrancis: once the present PR merges, I will cherry-pick it on top of cluster-autoscaler-release-1.30, cluster-autoscaler-release-1.31, cluster-autoscaler-release-1.32, cluster-autoscaler-release-1.33 in new PRs and assign them to you.

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.32
/cherry-pick cluster-autoscaler-release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fkrestan
Copy link

Hi! Just wanted to express support for this PR - the updated Azure SKU list would be very helpful for our workloads. May I kindly ask if there are any outstanding requirements or blockers preventing further review or approval? If there’s anything I can do to assist or help move this forward, I’d be happy to contribute.

@rakechill
Copy link
Contributor

I have no issues with merging (and will approve). However, were you running into SKU not found issues? @fkrestan @yanjar
All clusters should be using dynamic listing of SKUs and thus not using this static list. If you ran into errors, can you share them?

@tallaxes
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2025
@tallaxes
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rakechill, tallaxes, yanjar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2025
@k8s-ci-robot k8s-ci-robot merged commit 722902d into kubernetes:master Nov 13, 2025
8 checks passed
@k8s-infra-cherrypick-robot

@jackfrancis: new pull request created: #8808

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.32
/cherry-pick cluster-autoscaler-release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@jackfrancis: new pull request created: #8809

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.32
/cherry-pick cluster-autoscaler-release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@jackfrancis: new pull request created: #8810

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.32
/cherry-pick cluster-autoscaler-release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@jackfrancis: new pull request created: #8811

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.32
/cherry-pick cluster-autoscaler-release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jackfrancis
Copy link
Contributor

/cherry-pick cluster-autoscaler-release-1.34

@k8s-infra-cherrypick-robot

@jackfrancis: new pull request created: #8812

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yanjar
Copy link
Contributor Author

yanjar commented Nov 13, 2025

I have no issues with merging (and will approve). However, were you running into SKU not found issues? @fkrestan @yanjar All clusters should be using dynamic listing of SKUs and thus not using this static list. If you ran into errors, can you share them?

@rakechill since AZURE_ENABLE_DYNAMIC_INSTANCE_LIST defaults to false, I was using the static list and getting Failed to get node infos for groups: instance type "Standard_D4s_v6" not supported.

@rakechill
Copy link
Contributor

@rakechill since AZURE_ENABLE_DYNAMIC_INSTANCE_LIST defaults to false, I was using the static list and getting Failed to get node infos for groups: instance type "Standard_D4s_v6" not supported.

Ah, it's different for our managed users. Sorry about that. We can also go ahead and default this to true for self-hosted. I'll make a PR today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants