Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
8329aea
Skip Kubernetes preloads and binary downloads when --no-kubernetes is…
divysinghvi Jul 25, 2025
c4b385f
Merge branch 'kubernetes:master' into no-kubernetes-skip-downloads
divysinghvi Jul 26, 2025
2338a97
Merge branch 'kubernetes:master' into no-kubernetes-skip-downloads
divysinghvi Aug 8, 2025
97f8852
Merge branch 'kubernetes:master' into no-kubernetes-skip-downloads
divysinghvi Aug 9, 2025
801ea3b
Added VerifyNoK8sDownloadCache test for check the v0.0.0 cache
divysinghvi Aug 10, 2025
57dfa41
Merge branch 'kubernetes:master' into no-kubernetes-skip-downloads
divysinghvi Aug 10, 2025
81a1198
Merge branch 'kubernetes:master' into no-kubernetes-skip-downloads
divysinghvi Aug 11, 2025
ac7ef42
Removed extra minikube instance by reusing the validateStartNoK8S ins…
divysinghvi Aug 11, 2025
99bf5f7
Fixed the path issue
divysinghvi Sep 17, 2025
de520ae
Merge branch 'master' into no-kubernetes-skip-downloads
divysinghvi Sep 17, 2025
85dc9bf
Added one more check in cache.go fixing the binary building issue, No…
divysinghvi Sep 25, 2025
f4817ca
Deleted Old test Directory
divysinghvi Sep 26, 2025
389ec44
Cleared Cache insde the VerifyNoK8sDownloadCache test and restarted w…
divysinghvi Sep 26, 2025
a0b3b30
Did not refresh the instance and logged the cache files to understand…
divysinghvi Sep 28, 2025
860101a
Updated VerifyNoK8sDownloadCache test
divysinghvi Oct 2, 2025
cbd40f5
ix Linux-specific cache directory creation in --no-kubernetes mode
divysinghvi Oct 2, 2025
acfd8b7
Added No-kubernetes flag check in TransferBinaries Function and also …
divysinghvi Oct 9, 2025
dd59be3
Merge branch 'kubernetes:master' into no-kubernetes-skip-downloads
divysinghvi Nov 6, 2025
9d0cf67
Merge branch 'kubernetes:master' into no-kubernetes-skip-downloads
divysinghvi Nov 9, 2025
c4345f2
Updated test to not fail when directory is present
divysinghvi Nov 9, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/minikube/download/binary.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (

"github.com/blang/semver/v4"
"github.com/pkg/errors"
"github.com/spf13/viper"
"k8s.io/klog/v2"
"k8s.io/minikube/pkg/minikube/localpath"
)
Expand Down Expand Up @@ -53,6 +54,11 @@ func binaryWithChecksumURL(binaryName, version, osName, archName, binaryURL stri

// Binary will download a binary onto the host
func Binary(binary, version, osName, archName, binaryURL string) (string, error) {
// Prevent Kubernetes binary downloads in --no-kubernetes mode
if viper.GetBool("no-kubernetes") {
klog.Infof("Skipping Kubernetes binary download due to --no-kubernetes flag")
return "", nil
}
targetDir := localpath.MakeMiniPath("cache", osName, archName, version)
targetFilepath := path.Join(targetDir, binary)
targetLock := targetFilepath + ".lock"
Expand Down
5 changes: 5 additions & 0 deletions pkg/minikube/download/preload.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,11 @@ var checkRemotePreloadExists = func(k8sVersion, containerRuntime string) bool {

// PreloadExists returns true if there is a preloaded tarball that can be used
func PreloadExists(k8sVersion, containerRuntime, driverName string, forcePreload ...bool) bool {
// Prevent preload logic in --no-kubernetes mode
if viper.GetBool("no-kubernetes") {
klog.Infof("Skipping preload logic due to --no-kubernetes flag")
return false
}
// TODO (#8166): Get rid of the need for this and viper at all
force := false
if len(forcePreload) > 0 {
Expand Down