Addons: helm based addons #21847

volatilemolotov · 2025-11-04T22:11:40Z

This PR adds support for addons based on helm.

Adds the following:

helmChart struct to addon. If this is defined code will go to helmCommand . If set to nil regular kubectl addon install happens
helmInstall is triggered which installs the helm binary based on arch. This was done to not add bloat to the binary/iso
uses values and value files to set --set and --values respectively. This way one can ship a value file to configure via embed.FS

Example impelentation:

In addons list in pkg/minikube/assets/addons.go

		"testaddon": NewAddon([]*BinAsset{
   	MustBinAsset(addons.TestAddonAssets, "test-addon/test-addon.yaml", vmpath.GuestAddonsDir, "test-addon-values.yaml", "0640"),
   	}, false, "testaddon", "3rd party (akvelon.com)", "volatilemolotov", "", nil, nil,
   	&HelmChart{
   		Name:      "testaddon",
   		Repo:      "oci://linktooci/chart",
   		Namespace: "testaddon",
   		Values:    []string{"service.type=NodePort"},
   		ValueFiles: []string{"/etc/kubernetes/addons/test-addon-values.yaml",},
   	},

Provides foundation for #21257

k8s-ci-robot · 2025-11-04T22:11:47Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: volatilemolotov
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-11-04T22:11:50Z

Hi @volatilemolotov. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

minikube-bot · 2025-11-04T22:12:03Z

Can one of the admins verify this patch?

medyagh · 2025-11-05T20:05:52Z

pkg/addons/helm.go

+	"k8s.io/minikube/pkg/minikube/vmpath"
+)
+
+func helmCommand(ctx context.Context, chart *assets.HelmChart, enable bool) *exec.Cmd {


add a comment explain in short what this func does?

Yeah, short description added

how about make this a Generic func, and have two other helpers
called
insatallHelmChart
uninstallHelmChart

so we dont have to pass the enable to it

Added installHelmChart and uninstallHelmChart along with helmUninstallOrInstall

pkg/addons/helm.go

medyagh · 2025-11-05T20:07:24Z

pkg/addons/helm.go

+		default:
+			return fmt.Errorf("failure to detect architecture or unsupported architecture: %s", arch)
+	}
+	helmURL := fmt.Sprintf("https://get.helm.sh/helm-v3.19.0-linux-%s.tar.gz", helmArch)


is there a "latest" helm url that we could use ?

Not aware of any available latest target.

changed this to get_helm.sh

medyagh · 2025-11-05T20:08:29Z

pkg/addons/helm.go

+func helmInstall(addon *assets.Addon, runner command.Runner) error {
+	_, err := runner.RunCmd(exec.Command("test", "-f", "/usr/bin/helm"))
+	if err != nil {
+		// If not, install it


how about installing it through their Script ?
https://helm.sh/docs/intro/install#from-script

this will install latest by script and no need for us to parse archs

Did not want to shoehorn a whole script into this but we could do that. It would require a chmod call and similar but doable. Ill see if its works

Actually not possible without changing either ISO or the script. Script will try to put helm into /usr/local/bin which the VM does not have. Issue encountered on macos with krunkit driver. Same happens on linux with kvm driver

Output from minikube ssh and $ ls /usr/

bin lib lib64 libexec sbin share

Ill revisit this one. Probably we can make the dir and copy the binary where it needs to be and satisfy both environments

Decided to go with checking if the folder exists and create it if it does not. Then copy helm binary to the PATH.

…inary

medyagh · 2025-11-05T21:35:01Z

pkg/addons/addons.go

+
+			ctx, cancel := context.WithTimeout(context.Background(), 2*time.Minute)
+			defer cancel()
+			cmd := helmCommand(ctx, addon.HelmChart, enable)


would this ever be called with disable?

medyagh · 2025-11-07T22:15:11Z

pkg/addons/addons.go

 		}
 		if strings.HasSuffix(fPath, ".yaml") {
 			deployFiles = append(deployFiles, fPath)
 		}


we can add a documentation to the website https://minikube.sigs.k8s.io/docs/contrib/addons/

we can add a block (how to add helm based addons)

Pushed a new site doc with some explanation. As we work on adding a actual addon we will update the doc for the helm based addon

volatilemolotov added 2 commits November 4, 2025 17:22

add support for helm based addons

ba89aec

refactor helm install

8b29c65

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 4, 2025

k8s-ci-robot requested a review from ComradeProgrammer November 4, 2025 22:11

k8s-ci-robot requested a review from nirs November 4, 2025 22:11

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 4, 2025

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2025

medyagh reviewed Nov 5, 2025

View reviewed changes

pkg/addons/helm.go Outdated Show resolved Hide resolved

medyagh reviewed Nov 5, 2025

View reviewed changes

medyagh requested changes Nov 5, 2025

View reviewed changes

add description to helmcommand and rename helminstall to helminstallb…

9e336a9

…inary

medyagh reviewed Nov 5, 2025

View reviewed changes

volatilemolotov added 2 commits November 6, 2025 22:17

refactor helm functions

82621d2

refactor helm functions - fix install and tests

d82101b

medyagh reviewed Nov 7, 2025

View reviewed changes

add documentation for the helm based addons

0cb66d3

Addons: helm based addons #21847

Are you sure you want to change the base?

Addons: helm based addons #21847

Conversation

volatilemolotov commented Nov 4, 2025

Uh oh!

k8s-ci-robot commented Nov 4, 2025

Uh oh!

k8s-ci-robot commented Nov 4, 2025

Uh oh!

minikube-bot commented Nov 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants