Skip to content

UI: remove confusing message related to podman #22024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
obnoxxx wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

UI: remove confusing message related to podman #22024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/minikube/node/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,8 @@ func beginDownloadKicBaseImage(g *errgroup.Group, cc *config.ClusterConfig, down
}

if cc.Driver == driver.Podman {
return fmt.Errorf("not yet implemented, see issue #8426")
klog.Infof("iskipping image load from cache: not implemented for podman. see issue #8426")
Copy link
Member

@medyagh medyagh Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can change this to warnningf

Copy link
Contributor

@nirs nirs Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

klog.Warningf is fine, but it should go only to the log (unless --alsologtostderr was used).

return nil
}
Copy link
Contributor

@nirs nirs Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only correct change - removing the bad fmt.Errorf. But it would be more correct to convert this to debug log like:

Skipping <operation description>: not implemented, see issue #8426

This will improve the user experience but make it easier to debug podman driver, in case skipping has negative effects. If this operation is not needed for podman removing the log is a better change, but I'm not sure what this code is doing and wha is the unimplemented operation that we skipped.

Copy link
Contributor Author

@obnoxxx obnoxxx Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. I will change the patch accordingly.

Copy link
Contributor Author

@obnoxxx obnoxxx Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, fwiw.

if driver.IsDocker(cc.Driver) && err == nil {
klog.Infof("Loading %s from local cache", img)
Expand Down