Skip to content

Conversation

@kannon92
Copy link
Contributor

Adding agents.md to test-infra repo.

This gives context to AI assistants and helps guide how to develop in this repo.

I generated this with claude init and moved that generated file to AGENTS.md.

Gemini and Claude are able to read the canoical AGENTS.md file with the @AGENTS.md.

I've added this into kueue and jobset.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 30, 2025
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry about having yet another set of disjoint docs to maintain, can we just tell it to read the README and the Makefile and add any missing details to those?

I think there's way too much info in here that will fall out of date as people that don't use these tools iterate on the makefiles etc.

Can we keep this to info that doesn't make sense for README.md, Makefile help text, developers docs, etc, IE acutal agent-specific instructions? (Such as pointing it to read in those files?)

Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with @BenTheElder 's comments.

I found it best to start with some agents.md and then iterate on it. I wonder if we should place AGENTS_IMPLEMENTATION.md in some subfolders with AGENTS.md linnking it, so we can add more owners for it.

AGENTS.md Outdated
- **Postsubmits**: Run after code is merged
- **Periodics**: Run on a schedule

### Adding or Updating Jobs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how much we will need to keep this section in root vs. inside the config/jobs/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I think a sub agents folder for config/jobs (espeically sig-node) could be helpful.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kannon92
Once this PR has been reviewed and has the lgtm label, please assign upodroid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2025
@kannon92
Copy link
Contributor Author

kannon92 commented Nov 8, 2025

#35820 (review)

@BenTheElder I updated this to tell agents file to read README.md and contributor guides as much as possible.

PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants