-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Fix kubeweekly section bug #53122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix kubeweekly section bug #53122
Conversation
|
|
|
Welcome @killjoycircuit! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Caesarsage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your first contribution and welcome to the community, @killjoycircuit!
I noticed that your changes also affected the “View past newsletters” anchor link — it’s now white instead of its original color, which made it easier to identify as a link. Could you please revert that change?
|
It's OK to fix this, but please also consider merging #51829 instead. |


Description
Fixes dark mode text visibility issue in the KubeWeekly newsletter signup section on the homepage. The text was displaying in black on the dark background making it unreadable for users browsing with dark mode enabled.
Changes:
Added dark mode styles for .section-feature#kubeweekly
Issue
Closes: #53121