Skip to content

Conversation

@killjoycircuit
Copy link

@killjoycircuit killjoycircuit commented Nov 8, 2025

Description
Fixes dark mode text visibility issue in the KubeWeekly newsletter signup section on the homepage. The text was displaying in black on the dark background making it unreadable for users browsing with dark mode enabled.

Changes:
Added dark mode styles for .section-feature#kubeweekly

Issue
Closes: #53121

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 8, 2025

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: killjoycircuit / name: Rutuj Dhawale (4b07745)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 8, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @killjoycircuit!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lmktfy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 8, 2025
@netlify
Copy link

netlify bot commented Nov 8, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 4b07745
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/690f806508b035000890932c
😎 Deploy Preview https://deploy-preview-53122--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@Caesarsage Caesarsage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution and welcome to the community, @killjoycircuit!

I noticed that your changes also affected the “View past newsletters” anchor link — it’s now white instead of its original color, which made it easier to identify as a link. Could you please revert that change?

Your changes:
image

Expected from the issue
image

@lmktfy
Copy link
Member

lmktfy commented Nov 10, 2025

It's OK to fix this, but please also consider merging #51829 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KubeWeekly section is unreadable in dark mode

4 participants