feat(helm): sync release-2.6 chart and support image pull secrets - #305
Conversation
Signed-off-by: Gentleelephant <1132960613@qq.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Helm chart to version 2.6.1 and introduces support for global imagePullSecrets in the operator deployment and service account. Feedback is provided regarding the decision to comment out the image tag keys in values.yaml, which reduces configuration readability; it is recommended to keep these keys uncommented and explicitly set.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| image: | ||
| repo: kubesphere/notification-manager-operator | ||
| tag: v2.6.0 | ||
| # tag: v2.6.1 |
There was a problem hiding this comment.
Commenting out the tag key in values.yaml makes the configuration less readable and harder for users to understand the default image version being used. It is better to keep the key uncommented and explicitly set to the current version, or set it to an empty string "" with a comment explaining that it defaults to the Chart's appVersion.
tag: v2.6.1| image: | ||
| repo: kubesphere/notification-manager | ||
| tag: v2.6.0 | ||
| # tag: v2.6.1 |
There was a problem hiding this comment.
Commenting out the tag key in values.yaml makes the configuration less readable and harder for users to understand the default image version being used. It is better to keep the key uncommented and explicitly set to the current version, or set it to an empty string "" with a comment explaining that it defaults to the Chart's appVersion.
tag: v2.6.1
e2db3e5 to
df32049
Compare
2 participants
No description provided.