Skip to content

Conversation

@sradco
Copy link
Contributor

@sradco sradco commented Nov 10, 2025

What this PR does / why we need it:
This PR adds an Observability Compatibility Policy.

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 10, 2025
@avlitman
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2025
@sradco sradco force-pushed the add_observability_policy branch from 6e3354f to bf6f435 Compare November 12, 2025 10:56
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2025
@sradco
Copy link
Contributor Author

sradco commented Nov 12, 2025

@avlitman @RamLavi please review again

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

Copy link
Collaborator

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@avlitman once you lgtm the PR should be OK to merge

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2025
@RamLavi
Copy link
Collaborator

RamLavi commented Nov 23, 2025

/approve

@avlitman once you lgtm the PR should be OK to merge

@avlitman ?

@avlitman
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2025
@RamLavi
Copy link
Collaborator

RamLavi commented Nov 24, 2025

/retest

1 similar comment
@RamLavi
Copy link
Collaborator

RamLavi commented Nov 24, 2025

/retest

@kubevirt-bot kubevirt-bot merged commit 8ead5de into kubevirt:main Nov 24, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants