-
Notifications
You must be signed in to change notification settings - Fork 53
logs: Reduce logs spamming and introduce levels #2491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove repetitive reconciliation logs. Signed-off-by: Or Shoval <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
Some logs that might worth to investigate on follow-ups.
Note that i dont see it on KCLI, just on k8s.
those are the should be moved to the container (but need to be tested that it still works afterwards) we do have both, maybe we can remove the deprecated one, in case its not needed anymore for BWC 2,3 repeat each reconcile before this PR cc @RamLavi fyi please |
|
/test pull-e2e-cluster-network-addons-operator-macvtap-cni-functests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I think it's a great idea to introduce leveled logs.
Could you have it configurable on the operator via some flag? This way, the could control how much logging they see.
done |
|
/hold need to fix something |
Allows to use levels. Signed-off-by: Or Shoval <[email protected]>
Signed-off-by: Or Shoval <[email protected]>
|
/hold cancel |
|
/retest |
|
updated findings to #2491 (comment) the 3rd issue is a real bug, the first is nice to fix as well, but self healing |
In order to enable set CNAO_LOG_LEVEL=-1. Signed-off-by: Or Shoval <[email protected]>
|
|
changes: Reduce verbosity of repetitive logs |
|
unrelated to this PR |
RamLavi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oshoval The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |



What this PR does / why we need it:
For example from a cluster that ran for a while:
Special notes for your reviewer:
Release note: